feat: standardized peerdas metrics #7095
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a PR related to this ethereum/beacon-metrics#13 |
Sweet. Ill read that more deeply. Looks like the branch I got these from is the one being merged in. Got it from Pari at ethpandops was looking for here: Ill add the couple for gossip and what not |
matthewkeil
added
the
status-do-not-merge
|
The spec is still being hammered out so some of the metric names may change. Will keep this PR open and update accordingly. |
|
Some of the metric were added in the gossipsub package here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Pari requested that these standardized metrics be added to Lodestar. Once matrix reconstruction is implemented, will implement the metrics in that function, added them to the metrics object for now though so they are available in that PR.
https://discord.com/channels/595666850260713488/1252403418941624532/1285889840746856498