-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add devnet-5 support #7246
Draft
ensi321
wants to merge
14
commits into
unstable
Choose a base branch
from
devnet-5
base: unstable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7246 +/- ##
============================================
- Coverage 48.75% 48.61% -0.14%
============================================
Files 601 603 +2
Lines 40222 40457 +235
Branches 2061 2065 +4
============================================
+ Hits 19609 19667 +58
- Misses 20575 20752 +177
Partials 38 38 |
ensi321
force-pushed
the
devnet-5
branch
2 times, most recently
from
December 14, 2024 01:29
7ae5f0f
to
324562a
Compare
* feat: refactor SeenAttestationDatas for SinlgeAttestation * feat: add SingleAttestation type * feat: ssz utils for SingleAttestation * feat: implement SingleAttestation for network processor and gossip queue * fix: add SingleAttestation for phase0 and altair * fix: define and publish SingleAttestation for all forks * Fix electra SingleAttestation type mapping * Update api and eventstream * Update validator client * Update attestation unit test variables * chore: SeenAttestationDatas unit tests * chore: sszBytes unit tests * Use CommitteeIndex type * refactor: get/set functions of SeenAttestationDatas * Always emit single_attestation event * Validation use new SeenAttDataKey * validateAttestationNoSignatureCheck first draft * Add aggregation and committee bits to cache * AttestationPool accepts SingleAttestation * Update SingleAttestation event stream * Update aggregate validation * Polish * Lint * fix check-types * Remove committee bit cache * Update attestation pool unit tests * Lint * Remove unused committeeBits from attestation data cache * Fix spec reference comment * fix: getSeenAttDataKeyFromSignedAggregateAndProof * Update beacon-api spec tests to run against v3.0.0-alpha.9 --------- Co-authored-by: Nico Flaig <[email protected]> Co-authored-by: NC <[email protected]>
…7256) * fix: select correct gossip type when publishing single attestation * Add SingleAttestation as alias to phase0 ssz types
* fix: remove aggregation bits from seen attestation cache * Allow passing null as aggregationBits to test pre-electra case * Only create aggregationBits once for the first attestation * Avoid second getSingleTrueBit call
…#7261) * fix: return correct type from attestation validation when using cache * Remove type casts * Remove unused import * Use ternary operator instead of if-else * Fix aggregationBits type issue * Add comment
* initial commit * Address comment * Lint
* Rename PartialPendingWithdrawal field * do not change creds type on consolidation * Use validator EB to process pending consolidation * lint
* Fix execution request parsing * lint * Rename type --------- Co-authored-by: Nico Flaig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.