Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(advtool): removing necessary parents #12858
base: dev
Are you sure you want to change the base?
fix(advtool): removing necessary parents #12858
Changes from 3 commits
22c6c54
5037c91
d6f2bc9
d3b4814
7c07706
7180d4d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не обязательно. На будущее. Есть крутое решение, чтобы не ебаться с присвоением переменных когда чет дропаешь в атом.
Переопределяешь Entered() и когда чет попадает внутрь - смотришь по изтайпу и присваиваешь в нужную переменную. Аналогично с Exited() - обнуляешь ссылки.
Позволяет держать логику присвоения ссылок на хуйню в атоме в одном месте, а значит - меньше шансов проебаться где-то. В кофеварке емнип такая штука у меня, если интересно - посмотри.