Skip to content

Commit

Permalink
Remove xl breakpoint; readme
Browse files Browse the repository at this point in the history
  • Loading branch information
CharlesTaylor7 committed Aug 9, 2023
1 parent 100109a commit f7cd062
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ In the interest of time, I elected to omit things that would be nice to have but

- My open search api key is exposed in the frontend JS code. Theoretically, I could create a server with apis that call out to Open Weather. And thus avoid passing my api key to the frontend. The worst can happen here is, that someone steals the key and I run out of free credits. I won't be charged for calls. For a production app, I would definitely introduce a server.

- Temperatures are in Farenheit, can't request Celsius currently.
- Temperatures are in Farenheit, no way to toggle to Celsius currently.

- The search query doesn't handle abbreviated state codes.
e.g.
"Chattanooga, Tennessee", or "Chattanooga" yields search results.
Expand Down
2 changes: 1 addition & 1 deletion src/components/WeatherDashboard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default function WeatherDashboard() {
const [dashboard, updateDashboard] = useDashboardState();
return (
<div className="flex w-full justify-center items-center">
<div className="w-4/5 md:w-2/3 xl:w-1/2 flex flex-col gap-5 m-5 justify-center items-start">
<div className="w-4/5 md:w-2/3 flex flex-col gap-5 m-5 justify-center items-start">
<header className="self-center bold text-2xl">Weather Dashboard</header>
<CitySearch />
<div className="flex flex-wrap gap-2">
Expand Down

0 comments on commit f7cd062

Please sign in to comment.