Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a health check endpoint that ignores ALLOWED_HOSTS check #45

Open
smaniotto opened this issue Jan 7, 2020 · 2 comments · May be fixed by #208
Open

Create a health check endpoint that ignores ALLOWED_HOSTS check #45

smaniotto opened this issue Jan 7, 2020 · 2 comments · May be fixed by #208

Comments

@smaniotto
Copy link
Contributor

The default health check endpoint for load balancers normally is "/", which by default returns a 404, and it sends the request with an internal IP host, that is blocked by ALLOWED_HOSTS checking, returning a 403.

A suggestion is creating a "/health-check" endpoint that simply returns a 200 back and creating a middleware to ignore allowed host checking for this endpoint. Ideas?
@smaniotto smaniotto mentioned this issue Jan 8, 2020
Merged
@rodolfolottin
Copy link
Contributor

rodolfolottin commented Oct 22, 2020 •
edited
Loading

I think that we can close this issue since Fred has already implemented it @CheesecakeLabs/backend

I am just not so sure about what @smaniotto is suggesting in "creating a middleware to ignore allowed host checking for this endpoint"

@fredericojordan
Copy link
Contributor

I think he means to not enforce the ALLOWED_HOSTS check on the "/health-check" endpoint.
The suggestion is to implement it through a Middleware.

@CaioTeixeira95 CaioTeixeira95 linked a pull request Apr 13, 2021 that will close this issue
Open
@CaioTeixeira95 CaioTeixeira95 linked a pull request Apr 15, 2021 that will close this issue
Feat: Create middleware to bypass the ALLOWED_HOSTS validation #208
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Create middleware to bypass the ALLOWED_HOSTS validation CheesecakeLabs/django-drf-boilerplate
3 participants
@fredericojordan @smaniotto @rodolfolottin