Add Terraform base setup for ECS infrastructure #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstrapasson
approved these changes
Jan 7, 2020
Comment on lines
+80
to
+85
| database = { | ||
| username = module.database.db_username, | ||
| password = module.database.db_password, | ||
| hostname = module.database.db_hostname, | ||
| name = module.database.db_name, | ||
| } |
There was a problem hiding this comment.
Nice! I didn't know that we can pass a object
| django_debug: "False", | ||
| app_bucket: var.app_bucket, | ||
| django_secret_key: var.backend_secret_key, | ||
| django_allowed_hosts: "*,", |
There was a problem hiding this comment.
Should not this configs be added in the variables.tf?
There was a problem hiding this comment.
Definitely. I didn't work much on this because of issue #45 and I think that env vars should work better with Terraform local values (https://www.terraform.io/docs/configuration/locals.html) instead of passing variables around, maybe as an object/hashmap. Can it be added as a future improvement?
Comment on lines
+34
to
+39
| vars = merge(var.container_env_vars, { | ||
| aws_region = var.region | ||
| container_name = "${var.project_name}-${var.alias_name}-${var.environment}" | ||
| cloudwatch_log_group = aws_cloudwatch_log_group.logs.name | ||
| container_image = "${aws_ecr_repository.ecr_repo.repository_url}:latest" | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a configuration to create an ECS cluster, database, bucket and all underlying structure to run a backend+frontend application. There is a README file that explains in more details how to use this configuration.
There are a few TODO comments that have to be addressed in the near future, but with this configuration we're already able to setup an infrastructure without the updates.
For mobile applications, that don't require a frontend, we still have to manually remove the frontend service.