-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor full_node add_block #18584
base: main
Are you sure you want to change the base?
refactor full_node add_block #18584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good!
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@arvid there are 2 options for updating the wallet in this case from what i can tell
still trying to understand whats the better path here, if its aggregating or just telling the wallet to resync i assume telling the wallet to resync since there is a limit to how much data we can aggregate and send in one go |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
1 similar comment
Conflicts have been resolved. A maintainer will review the pull request shortly. |
f279e9b
to
f82fc1b
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
a01d200
to
f82fc1b
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good. I have a few questions. Was it deliberate to add the __init__.py
file?
Purpose:
full node add_block is only used to add blocks on top of the current Peak, it does not need ForkInfo besides from the usage in tests, this pr removes that field and updates all the tests, this allows us to remove cases from blockchain.py add_block that dont serve us in node operation
Current Behavior:
New Behavior:
Testing Notes: