-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #183 #185
Fixes #183 #185
Conversation
I'm more inclined to remove the column count tests unless we can comment why they're relevant. I would also like to add some additional comments about what these tests are doing. |
@geneorama I think we will have a better answer about the column questions when we resolve #184. The test description is "Warn instead of fail if X-SODA2-* headers are missing" and we could add to that after resolving #184 as well. If you want to remove the column checks while #184 is open I don't see an issue with that. |
@nicklucius can you review please? Made changes based on our conversation. I don't think the checks for data frame or column numbers were related to the original issue. The column number check was the part that was failing, so to me the cleanest way is to adjust the test. |
Based on the verbal discussion, good idea to add the message relating to issue 118 |
Looks good @geneorama |
@nicklucius thanks. Glad we could get this knocked out. |
Due to a change in an upstream data source, test code had broken. This fixes that code.