Ensure that the execution batching provider is disposed. (#7831)

ChilliCream · Dec 16, 2024 · 6747630 · 6747630
1 parent 5ccdc28
commit 6747630
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/HotChocolate/Core/src/Fetching/BatchScheduler.cs b/src/HotChocolate/Core/src/Fetching/BatchScheduler.cs
@@ -17,6 +17,7 @@ public sealed class BatchScheduler : IBatchHandler
     private readonly List<Func<ValueTask>> _tasks = [];
     private bool _dispatchOnSchedule;
     private readonly List<EventHandler> _listeners = [];
+    private bool _disposed;
 
     /// <inheritdoc />
     public event EventHandler TaskEnqueued
@@ -219,4 +220,13 @@ private async Task DispatchOnEnqueue(Func<ValueTask> dispatch)
             _semaphore.Release();
         }
     }
+
+    public void Dispose()
+    {
+        if (!_disposed)
+        {
+            _semaphore.Dispose();
+            _disposed = true;
+        }
+    }
 }
diff --git a/src/HotChocolate/Core/src/Fetching/IBatchHandler.cs b/src/HotChocolate/Core/src/Fetching/IBatchHandler.cs
@@ -5,4 +5,4 @@ namespace HotChocolate.Fetching;
 /// <summary>
 /// The execution engine batch scheduler and dispatcher.
 /// </summary>
-public interface IBatchHandler : IBatchDispatcher, IBatchScheduler;
+public interface IBatchHandler : IBatchDispatcher, IBatchScheduler, IDisposable;