Add support for select multiple request. #1130

rohitjakhar · 2023-11-22T07:55:05Z

📷 Screenshots

📄 Context

Issue link: Share Multiple Request at One Time

📝 Changes

Made change in TransactionAdapter to show color on Selected. Transaction, list of selected position, lambda for longClick on itemView.
Also Add query for get selected transaction data, delete transaction data.

🛠️ How to test

Long press at any transaction to select transaction, after that click other transaction to select them too.

Add support for share selected Transaction as text and har file type. Add support for delete selected transaction only.

Fix Adapter parameters.

rohitjakhar · 2023-11-22T14:46:39Z

@cortinico what should i do next?

cortinico

Thanks for sending this over. I've done a first pass. We need to do more testing as currently the logic is broken, see this video:

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/MainActivity.kt

cortinico · 2023-11-25T18:15:20Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/MainActivity.kt

@@ -148,15 +168,16 @@ internal class MainActivity :
                showDialog(
                    getClearDialogData(),
                    onPositiveClick = {
-                        viewModel.clearTransactions()
+                        if (selectedTransactions.isNotEmpty()) viewModel.clearSelectedTransactions(selectedTransactions) else viewModel.clearTransactions()


Can we move this logic inside hte ViewModel? Let's just have a viewModel.clearTransactions(selectedTransactions) that behaves differently wether the selectedTransactions is empty or not

library/src/main/res/values/strings.xml

Co-authored-by: Nicola Corti <[email protected]>

rohitjakhar · 2023-11-26T05:15:04Z

Thanks @cortinico for review, i will try to fix that ASAP.

cortinico · 2023-12-04T14:51:39Z

@rohitjakhar Just to set expectations, I'll be able to take a look at this only next week.

…are_multiple_request # Conflicts: # library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/MainActivity.kt # library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt

rohitjakhar · 2023-12-16T09:26:23Z

@cortinico I resolve conflicts, test all corner cases.

cortinico · 2024-01-08T14:36:30Z

@rohitjakhar sorry I've been off for XMas vacation and haven't had time to look at this again. I can look into it this week so we can merge it. Could you fix the detekt/ktlint failures in the meanwhile?

cortinico

Thanks again for sending this over @rohitjakhar

Please reformat the code with ./gradlew ktlintFormat as formatting is odd in a couple of places.

Also there is a problem with rotation of the device: the highlights is lost, but the selection still remains. Also clicking delete is deleting the wrong transaction. See the video I'm attaching.

cortinico · 2024-01-13T23:58:56Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt

+) : ListAdapter<
+    HttpTransactionTuple,
+    TransactionAdapter.TransactionViewHolder>(
+    TransactionDiffCallback


The formatting here is odd and is causing ktlint to fail

cortinico · 2024-01-14T00:00:29Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt

        }

        @SuppressLint("SetTextI18n")
        fun bind(transaction: HttpTransactionTuple) {
            transactionId = transaction.id
-
+            if (selectedPos.find { it == adapterPosition } != null) {
+                itemView.setBackgroundColor(color400)


Let's not used this.
Let's create a new color resource as:

<color name="chucker_status_highlighted">#FF9800</color>

cortinico · 2024-01-14T00:02:15Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt

+                    }
+                    notifyItemChanged(adapterPosition)
+                    true
+                } ?: kotlin.run { false }


Suggested change

} ?: kotlin.run { false }

} ?: false

cortinico · 2024-01-14T00:02:37Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt

+        context.theme.resolveAttribute(
+        android.R.attr.selectableItemBackground,
+        outValue,
+        true,
+    )


formatting is odd also here

cortinico · 2024-01-14T00:06:33Z

We're getting close to a mergeabble state :)

Review Changes.

rohitjakhar · 2024-02-01T11:42:22Z

@cortinico I fix above issues.

rohitjakhar · 2024-03-27T12:15:32Z

@cortinico can you give me next step to merge it?

cortinico

Let's make sure the CI is green 👍 You also need to run ./gradlew ktlintFormat before resubmitting

cortinico · 2024-04-07T17:49:39Z

library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/MainActivity.kt

+                    getExportDialogData(
+                        if (viewModel.isItemSelected.value == true) {
+                            R.string.chucker_export_text_selected_http_confirmation
+                        } else {
+                            R.string.chucker_export_text_http_confirmation
+                        },
+                    ),


Because of this, the function is now getting too long and letting detekt fail:

> Task :library:detekt /home/runner/work/chucker/chucker/library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/MainActivity.kt:161:18: The function onOptionsItemSelected is too long (60). The maximum length is 60. [LongMethod]

You can see it in the CI signal.

Can you export this + lines 193/199 to separate functions

…into share_multiple_request

rohitjakhar · 2024-06-06T14:31:19Z

@cortinico I just update code and run ktlintformat.

rohitjakhar · 2024-06-06T16:51:21Z

@cortinico should i supress TooManyFunctions ?

cortinico · 2024-06-07T09:06:07Z

@cortinico should i supress TooManyFunctions ?

Yes please do, it's reasonable to do so in MainActivity.kt

rohitjakhar · 2024-06-13T14:42:54Z

@cortinico All are green

cortinico · 2024-06-20T22:48:36Z

@rohitjakhar thanks for following up.

Sadly there are still a couple of bugs:

The 4xx transactions are rendered impossible to read (see screnshot). We should probably change the text color to black when things are selected.

If you quickly select transactions as they're getting populated, you end up in a broken state where not all selected transactions are actually deleted. See video:

video-1718923534.mp4

Can I ask you to look into those 2 problems and then we can merge it 👍

rohitjakhar added 2 commits November 22, 2023 12:11

Add Multiple Section in transaction list.

73437f8

Add support for share selected Transaction as text and har file type. Add support for delete selected transaction only.

Fix variable naming.

6a9eb8d

Fix Adapter parameters.

rohitjakhar requested a review from a team as a code owner November 22, 2023 07:55

rohitjakhar mentioned this pull request Nov 22, 2023

Share Multiple Request at One Time #1127

Open

2 tasks

Fix ktlint

abdb4c5

cortinico requested changes Nov 25, 2023

View reviewed changes

rohitjakhar and others added 3 commits November 26, 2023 10:43

Concise code.

0850127

Co-authored-by: Nicola Corti <[email protected]>

Update library/src/main/res/values/strings.xml

d80d386

Co-authored-by: Nicola Corti <[email protected]>

Update library/src/main/res/values/strings.xml

d453d6d

Co-authored-by: Nicola Corti <[email protected]>

rohitjakhar added 3 commits November 29, 2023 16:11

Notify adapter after deleting item from list.

7dad7ff

move selected item code inside viewmodel.

882d623

fix reselecting. click after clear selection issue.

9e41073

Merge branch 'main' of https://github.com/rohitjakhar/chucker into sh…

5b58ed1

…are_multiple_request # Conflicts: # library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/MainActivity.kt # library/src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionAdapter.kt

Fix deket

4a8ecdd

cortinico requested changes Jan 14, 2024

View reviewed changes

rohitjakhar added 2 commits February 1, 2024 15:05

KotlinLint Format

5ce5445

Review Changes.

Fix: Persistent user selection

05427fe

cortinico requested changes Apr 7, 2024

View reviewed changes

rohitjakhar added 2 commits June 6, 2024 19:52

Merge branch 'main' of https://github.com/rohitjakhar/ComposeChucker …

d5461e4

…into share_multiple_request

Update code.

c107409

Suppress MainActivity with TooManyFunction.

137d8c7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for select multiple request. #1130

Add support for select multiple request. #1130

rohitjakhar commented Nov 22, 2023

rohitjakhar commented Nov 22, 2023

cortinico left a comment

cortinico Nov 25, 2023

rohitjakhar commented Nov 26, 2023

cortinico commented Dec 4, 2023

rohitjakhar commented Dec 16, 2023

cortinico commented Jan 8, 2024

cortinico left a comment

cortinico Jan 13, 2024

cortinico Jan 14, 2024

cortinico Jan 14, 2024

cortinico Jan 14, 2024

cortinico commented Jan 14, 2024

rohitjakhar commented Feb 1, 2024

rohitjakhar commented Mar 27, 2024

cortinico left a comment

cortinico Apr 7, 2024

rohitjakhar commented Jun 6, 2024

rohitjakhar commented Jun 6, 2024

cortinico commented Jun 7, 2024

rohitjakhar commented Jun 13, 2024

cortinico commented Jun 20, 2024

Add support for select multiple request. #1130

Are you sure you want to change the base?

Add support for select multiple request. #1130

Conversation

rohitjakhar commented Nov 22, 2023

📷 Screenshots

📄 Context

📝 Changes

🛠️ How to test

rohitjakhar commented Nov 22, 2023

cortinico left a comment

Choose a reason for hiding this comment

cortinico Nov 25, 2023

Choose a reason for hiding this comment

rohitjakhar commented Nov 26, 2023

cortinico commented Dec 4, 2023

rohitjakhar commented Dec 16, 2023

cortinico commented Jan 8, 2024

cortinico left a comment

Choose a reason for hiding this comment

cortinico Jan 13, 2024

Choose a reason for hiding this comment

cortinico Jan 14, 2024

Choose a reason for hiding this comment

cortinico Jan 14, 2024

Choose a reason for hiding this comment

cortinico Jan 14, 2024

Choose a reason for hiding this comment

cortinico commented Jan 14, 2024

rohitjakhar commented Feb 1, 2024

rohitjakhar commented Mar 27, 2024

cortinico left a comment

Choose a reason for hiding this comment

cortinico Apr 7, 2024

Choose a reason for hiding this comment

rohitjakhar commented Jun 6, 2024

rohitjakhar commented Jun 6, 2024

cortinico commented Jun 7, 2024

rohitjakhar commented Jun 13, 2024

cortinico commented Jun 20, 2024