Use parametrized type tokens for GSON converters #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
approved these changes
Jan 25, 2024
|
@koral-- can you update the CHANGELOG.md file as well? |
Fixes "TypeToken must be created with a type argument: new TypeToken<...>() {}; When using code shrinkers (ProGuard, R8, ...) make sure that generic signatures are preserved." errors.
koral--
force-pushed
the
r8-param-types
branch
from
84c4e7f to
cdb452c
Compare
|
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "TypeToken must be created with a type argument: new TypeToken<...>() {}; When using code shrinkers (ProGuard, R8, ...) make sure that generic signatures are preserved." errors.
📷 Screenshots
N/A
📄 Context
One may use Chucker with optimized builds.
📝 Changes
Change how type tokens for lists are created so it works also in optimized/shrinked builds.
Just a different GSON API is now used, no changes in effects.
📎 Related PR
N/A
🚫 Breaking
Nothing
🛠️ How to test
Use chucker (standard, not no-op) with a release build type or enable minification in debug build type.
⏱️ Next steps
N/A