Implemented copy feature #1300
Merged
Implemented copy feature #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanandyadav11
approved these changes
Oct 18, 2024
shivanandyadav11
approved these changes
Oct 20, 2024
cortinico
reviewed
Oct 28, 2024
...rc/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadFragment.kt
Show resolved
Hide resolved
|
@cortinico Changes are done please review it. Thanks |
cortinico
reviewed
Dec 7, 2024
There was a problem hiding this comment.
Code looks good @A7ak only a couple nits.
There is a problem with the icon in dark mode though (see screenshot below). The icon should be transparent while it's not. Plus I feel we should make it #ffffff as the icon on the top bar.
Could you look into it? After this we can merge it 👍
...rc/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadFragment.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadAdapter.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/com/chuckerteam/chucker/internal/ui/transaction/TransactionPayloadAdapter.kt
Outdated
Show resolved
Hide resolved
|
@cortinico requested changes done please review it. |
cortinico
approved these changes
Dec 8, 2024
|
Thanks, @cortinico learned a lot while working on the copy feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
Fixes #1299
📝 Changes
Added a button to copy the response