add flow-edges from users with trusted tokens to organizations #40
Conversation
src/safe_db/db.rs
Outdated
| if balance == &U256::from(0) { | ||
| continue; | ||
| } | ||
| organization_accepted_tokens.get(token).map(|organizations| { |
There was a problem hiding this comment.
Does this compile? The function passed to map does not return anything.
Maybe if let Some(organizations) = rganization_accepted_tokens.get(token) {?
There was a problem hiding this comment.
or use something like flat_map and for_each
There was a problem hiding this comment.
organization_accepted_tokens.get(token) returns an Option<HashSet<Address>> so the method used is https://doc.rust-lang.org/std/option/enum.Option.html#method.map and not https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.map
|
Does it work? :) |
|
|
||
| // Find all safes that have a non-zero balance of tokens that are accepted by an organization | ||
| for (user, safe) in &self.safes { | ||
| for (token, balance) in &safe.balances { |
There was a problem hiding this comment.
Meaning of balance.token
It's not clear to me what the token attribute of an Edge represents. Is it a token address, or a user address (i.e. the owner of the token)? Compare these 2 cases, where in the first it is assumed that the balance contains the token address, and in the second the token attribute of the balance is supposed to contain the token owner address:
- https://github.com/CirclesUBI/pathfinder2/blob/5950ab81b2d1adf36354e3b9e7bc5b16e0a97874/src/safe_db/db.rs#L94C1-L103C1
- https://github.com/CirclesUBI/pathfinder2/blob/5950ab81b2d1adf36354e3b9e7bc5b16e0a97874/src/safe_db/db.rs#L55C1-L68C4
I think the problem lies in the confusion created by the edge.token which we are using to store the token owner address. Correct me if I'm wrong. I suggest changing the name of the edge.token attribute to edge.token_owner once and for all.
There was a problem hiding this comment.
can we create a test image to update the pathfinder in production @jaensen ?
There was a problem hiding this comment.
In my PR (#43), I assumed that balance.token is a token address and not a token's owner address. So the issue reported in my comment would be fixed there.
…feature/add-user-balance-to-org-flow-edges
|
already added in the only-server |
No description provided.