Modify default call to pmap when paralellizing #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the discussion in Circuitscape#236.
VLucet
changed the title
Pull Request Test Coverage Report for Build 654
💛 - Coveralls |
|
Unsure why Appveyor is failing. Related to #188 ? |
Yeah don't worry about that failure for now. It's failing on master too. Not your doing 🙂 |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the discussion in #236.
By default,
core.jlmakes use ofpmap. However, this is problematic if the user wishes to parallelize Circuitscape at a higher level than the pairs level. I change the solver functions to usemapby default and only usepmapwhen the users setsparallelizeexplicitly.