[minor_change] add all attributes to mo output for check_mode delete #446
Conversation
akinross
requested review from
annegentle,
lhercot,
shrsr,
sajagana,
abrahammughal and
gmicol
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 91.16% 91.11% -0.05%
==========================================
Files 178 178
Lines 7925 7927 +2
Branches 1173 1173
==========================================
- Hits 7225 7223 -2
- Misses 594 597 +3
- Partials 106 107 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
| @@ -1657,7 +1657,9 @@ def dump_json(self): | |||
|
|
|||
| elif self.params.get("state") == "absent" and self.existing: | |||
| for aci_class in self.existing[0]: | |||
| mo[aci_class] = dict(attributes=dict(dn=dn_path, status="deleted")) | |||
| attributes = deepcopy(self.existing[0][aci_class]["attributes"]) | |||
There was a problem hiding this comment.
Do we need to include all the attributes or will just name do?
There was a problem hiding this comment.
This change is still to be decided because it is actually a NDI issue (bug already identified).
However if we do decide to make changes name will likely not be suffice. I think the identifier of the class is required by NDI, triggering the error of name for name attribute. But other classes can have different identifiers, thus I think more attributes should be exposed. Since we don't keep track of these identifier attributes we either expose all ( generic few lines of code ) or need to make changes per module to add the identifier attributes to the mo output.
fixes #433