Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HL-677: Failing MinIO tests #1860

Merged
merged 1 commit into from
Feb 24, 2023
Merged

HL-677: Failing MinIO tests #1860

merged 1 commit into from
Feb 24, 2023

Conversation

mjturt
Copy link
Contributor

@mjturt mjturt commented Feb 22, 2023

As explained in the new readme, the tests freeze time and that's why MinIO requests fail.

Some discussion related to the issue here. The PR to freezegun that would allow S3 related utilities to be ignored from time freeze (and probably fix this) is still open.

Possible solutions

  1. Leave it as it is for now. Run tests minio disabled. I think this is ok, at least until we know more about our production environment, but no longer.
  2. Remove time freezing from tests and let tests run in current time. Probably requires great effort.
  3. Replace freezegun with a library that can ignore S3 utils properly. Freezegun has an "ignore library" configuration option, it's just not working for botocore etc. One possibility mentioned in freezegun's PR discussion would be time-machine. Most likely less effort than option 2.
  4. Clock faking isn't a long-term solution.

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rikuke
Copy link
Collaborator

rikuke commented Feb 24, 2023

Yeah because of the renewed uncertainty about the production environment, we can let this be at it is for the time being and just set the USE_S3=False to use the local disk as before. When we know what type of storage we'll be using in prod, we can revisit this and either remove Minio and Boto etc or fix this issue.

@mjturt mjturt merged commit f9b0f33 into develop Feb 24, 2023
@mjturt mjturt deleted the HL-677-fix-tests-with-minio branch February 24, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants