Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect progress percentage calculation #7

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: incorrect progress percentage calculation #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tftpd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,9 @@ class receiver : public server
if (dp_->th_opcode == DATA) {
// NOLINTNEXTLINE(cppcoreguidelines-pro-type-union-access)
if (dp_->th_block == block) {
if (g_tsize != 0) { // NOTE: prevent division by zero! CK
size_t const percent = 100UL * (block * g_segsize) / g_tsize;
if (g_tsize != 0 && g_segsize != 0) { // NOTE: prevent division by zero! CK
auto totalBlocks = g_tsize / g_segsize + ((g_tsize % g_segsize) > 0 ? 1 : 0);
size_t const percent = (100UL * block) / totalBlocks;
if (percent != percent_) {
syslog(LOG_NOTICE, "tftpd: Progress: %lu%% received\n", percent);
percent_ = percent;
Expand Down
Loading