Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pipfile.lock - rely on cached/artifact #834

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Drop pipfile.lock - rely on cached/artifact #834

merged 1 commit into from
Oct 31, 2023

Conversation

fizyk
Copy link
Member

@fizyk fizyk commented Oct 31, 2023

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_numer either from issue tracker or the Pull request number

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13e1db6) 95.45% compared to head (31bd5c1) 90.90%.

❗ Current head 31bd5c1 differs from pull request most recent head dfb504e. Consider uploading reports for the commit dfb504e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   95.45%   90.90%   -4.55%     
==========================================
  Files          13       13              
  Lines         396      396              
==========================================
- Hits          378      360      -18     
- Misses         18       36      +18     
Flag Coverage Δ
unittests 90.90% <ø> (-4.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fizyk fizyk merged commit e1c93a3 into main Oct 31, 2023
64 checks passed
@fizyk fizyk deleted the pipenv-skip-lock branch October 31, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants