Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to previous path / restart path #150

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

11phc
Copy link
Contributor

@11phc 11phc commented Sep 9, 2024

Added actions for go to previous path, restart existing path, and go to previous path index segment (which I'm not sure how useful it will be, but it's there now anyway).

These are useful for manually telling the mower to repeat bits it has gotten stuck on or done badly and so on.

@11phc 11phc changed the title Prev path Go to previous path / restart path Sep 9, 2024
@rovo89
Copy link
Contributor

rovo89 commented Sep 12, 2024

Sorry for hijacking this PR, but since you got yourself familiar with the skip back/ahead topic, I was wondering what you think about the following. I'm working on building a "playlist" feature, where a separate node manages the list of areas to mow right now, along with some settings, and instructs mower_logic to mow certain paths. My thought is that controls like the ones you implemented and proposed would be handled by the new node. Especially jumping back wouldn't be possible for mower_logic to handle as it will only knows the calculated paths for the current area.

For the implementation, I was thinking about sending an "abort" command first if any of the actions are triggered and then sending a new command with the adjusted area/path/index. Do you see any issues with that?

@11phc
Copy link
Contributor Author

11phc commented Sep 12, 2024

Hi Robert, I am perhaps not the right person to ask as my knowledge is not that in depth on the overall workings of the logic. A new node with a playlist feature sounds a good idea and might ultimately be able to supersede the current sequential functionality, which is not ideal at all for multiple and complicated areas. My actions I have implemented here could run alongside yours and then perhaps ultimately be deprecated once your system is up and running smoothly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants