Skip to content

Commit

Permalink
Merge pull request #112 from Clever/INFRANG-5322
Browse files Browse the repository at this point in the history
remove log that is never used
  • Loading branch information
tnsardesai authored Sep 29, 2023
2 parents d9cc6be + 3ec2e32 commit a57f6ea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
4 changes: 2 additions & 2 deletions VERSION
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
v0.7.2
Truncate error messages to fit within AWS limits.
v0.7.3
Remove logs tracking start and end time of exec
7 changes: 0 additions & 7 deletions cmd/sfncli/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,6 @@ func (t *TaskRunner) Process(ctx context.Context, args []string, input string) e
// forward signals to the command, handle SIGTERM
go t.handleSignals(ctx)

if tmpDir == "" {
t.logger.TraceD("exec-command-start", logger.M{"args": args, "cmd": t.cmd})
} else {
t.logger.TraceD("exec-command-start", logger.M{"args": args, "cmd": t.cmd, "workdirectory": tmpDir})
}
start := time.Now()
if err := t.execCmd.Run(); err != nil {
stderr := strings.TrimSpace(stderrbuf.String()) // remove trailing newline
customError, _ := parseCustomErrorFromStdout(stdoutbuf.String()) // ignore parsing errors
Expand All @@ -142,7 +136,6 @@ func (t *TaskRunner) Process(ctx context.Context, args []string, input string) e
}
return t.sendTaskFailure(TaskFailureUnknown{err})
}
t.logger.InfoD("exec-command-end", logger.M{"duration_ns": time.Since(start)})

// AWS / states language requires JSON output
taskOutput := taskOutputFromStdout(stdoutbuf.String())
Expand Down

0 comments on commit a57f6ea

Please sign in to comment.