Migrate to svelte-bootstrap-icons
#303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to note is that this will introduce slight inconsistency into the site (as Bootstrap icons update, the icons on the website will update as well). I think this is worth the code reduction. |
|
I needed to resolve some conflicts with Also one of the changes in this PR is
it would be good to verify that the SR prompts in cff882f are good (feel free to push any edits) |
dmlb
reviewed
Jul 27, 2023
dmlb
reviewed
Jul 27, 2023
dmlb
reviewed
Jul 27, 2023
- dark mode helper text flip for action - add slot name for back to top icon - default to link download undefined for svelte exclude attribute by default - update home page links to ButtonLinks component and adjust icon position on resources to look like similar spacing as youtube play
dmlb
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Related issue number/link
Fixes #304