New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search resources #306

Merged

VeckoTheGecko merged 12 commits into ClimateTown:main from christina-ml:search-resources

Aug 28, 2023

Contributor

christina-ml commented Aug 1, 2023 •

edited by VeckoTheGecko

Loading

Describe your changes

Added search bar filter and moved it into its own component to filter resources

Related issue number/link

Fixes #296

Thanks for contributing! 🥳🚀🌳

christina-ml and others added 3 commits

August 1, 2023 16:06


          Add form for search filter and moving search into its own component

159abf6


          Update yarn.lock

f2d16cc


          [pre-commit.ci] auto fixes from pre-commit.com hooks

6a554cf

for more information, see https://pre-commit.ci

dmlb reviewed

View reviewed changes

src/routes/resources/+page.svelte Outdated Show resolved Hide resolved

dmlb reviewed

View reviewed changes

src/lib/components/Search.svelte Outdated Show resolved Hide resolved

dmlb reviewed

View reviewed changes

src/lib/components/Search.svelte Outdated Show resolved Hide resolved

dmlb reviewed

View reviewed changes

src/lib/components/Search.svelte Outdated Show resolved Hide resolved

dmlb reviewed

View reviewed changes

src/routes/resources/+page.svelte Outdated Show resolved Hide resolved

Collaborator

VeckoTheGecko commented Aug 3, 2023

Hi @christina-ml , thanks for the PR! Would you be able to provide some insight into how the implemented search functionality differs from fuzzy searching packages like Fuse.js? (https://www.fusejs.io/) Would fusejs be a quick, free way to offload some code and get some good search functionality for the codebase in return?

christina-ml added 4 commits

August 3, 2023 15:04


          Add background color from white to transparent.

Align form to the left by removing padding and adding margin to the bottom.


          Remove import for Collapsible

e4b671e

Change lib// to $lib/ for importing Search.svelte
Remove unused variables: searchResults and mainH1El


          Merge branch 'search-resources' of github.com:christina-ml/knowledge-…

5f8f02c

…hub into search-resources


          Add role search to form and input tags for Search.svelte

ec45919

VeckoTheGecko mentioned this pull request

Created NASA tag #318

Closed


          Add fuse.js for fuzzy searching

175fe8b

Contributor Author

christina-ml commented Aug 15, 2023

@VeckoTheGecko Added fuse.js to implement fuzzy searching.
Installed fuse.js with command npm install fuse.js
Set the threshold to 0.25 which matches close enough to most searches I tested.

pre-commit-ci bot and others added 2 commits

August 15, 2023 20:45


          [pre-commit.ci] auto fixes from pre-commit.com hooks

815489c

for more information, see https://pre-commit.ci


          Use ButtonLinks component for light/dark/hover

1e52836

Contributor Author

christina-ml commented Aug 15, 2023 •

edited

Loading

@VeckoTheGecko @dmlb I have resolved all above changes on this pull request.

dmlb approved these changes

View reviewed changes

VeckoTheGecko reviewed

View reviewed changes

src/routes/resources/+page.svelte Outdated Show resolved Hide resolved

Collaborator

VeckoTheGecko commented Aug 21, 2023 •

edited

Loading

As a point of discussion: how should the search work when there are also tags being used? At the moment, the search bar and the tag filter are completely independent and don't work in conjunction (which is fine by me). Is there a way that this can be made clearer in the UI? Or is the visual separation between the search bar and the tag filters enough?

EDIT: Let's leave this for a future conversation :)

VeckoTheGecko and others added 2 commits

August 28, 2023 12:55


          Remove 'tags' from fusejs keys

d876e2b


          Merge branch 'main' into search-resources

66dc918

VeckoTheGecko merged commit 8ee18f8 into ClimateTown:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet