Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚂 Resource onboarding (13 August 2023) #316

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Conversation

VeckoTheGecko
Copy link
Collaborator

All aboard! 🚂🚂🚂🚂

In this onboarding we add the following resources:

Thank you to our contributors for these resources! 🥳🌳

This PR was curated with help from the onboarding.py script. 🤖

@VeckoTheGecko
Copy link
Collaborator Author

@JarrodBaniqued would you like to suggest any copy edits to descriptions as part of this onboarding?

@JarrodBaniqued
Copy link
Contributor

Yes, I'm looking through it right now.

1 similar comment
@JarrodBaniqued

This comment was marked as duplicate.

@JarrodBaniqued
Copy link
Contributor

JarrodBaniqued commented Aug 13, 2023

Done. Only three changes, "U.S.-based" should replace "US-based" a period should be placed in the description for the new NASA page, and (I was unable to comment during the review process but) I have also created a pull request to add the new NASA tag as appropriate to all three resources.

@JarrodBaniqued JarrodBaniqued mentioned this pull request Aug 13, 2023
@JarrodBaniqued
Copy link
Contributor

JarrodBaniqued commented Aug 13, 2023 via email

Copy link
Collaborator Author

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementing feedback from #316 (comment)

data/resources.yml Outdated Show resolved Hide resolved
data/resources.yml Outdated Show resolved Hide resolved
@VeckoTheGecko
Copy link
Collaborator Author

Done! Thanks for the review. Merging 🚂🚂🚂🚂🚂🚂🚂🚂🚂🚂🚂🚂🚂

@VeckoTheGecko VeckoTheGecko merged commit da388b7 into main Aug 15, 2023
1 of 2 checks passed
@VeckoTheGecko VeckoTheGecko deleted the onboarding/2023-08-14 branch August 15, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants