Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved linkchecking #324

Merged
merged 9 commits into from
Aug 21, 2023
Merged

Improved linkchecking #324

merged 9 commits into from
Aug 21, 2023

Conversation

VeckoTheGecko
Copy link
Collaborator

@VeckoTheGecko VeckoTheGecko commented Aug 17, 2023

Describe your changes

Added Lychee linkchecking action workflow to the repo to go through repo files looking for broken links (404s etc). The workflow:

  • Runs Lychee, checking for broken links. Generates a report with findings. Workflow always passes regardless of broken links
  • If broken links found:
  • If no broken links found:

Issue #322 in this case acts as the main mechanism for surfacing these broken links, in a way that is minimally intrusive (doesn't mess with GHA failures) and interested parties can subscribe to the issue.

Related issue number/link

Fixes #319

@dmlb
Copy link
Contributor

dmlb commented Aug 20, 2023

This is cool :D

@VeckoTheGecko
Copy link
Collaborator Author

This is cool :D

I thought so too 😁 . Really nice way to manage the links.

Thanks for the review @dmlb !

@all-contributors please add @dmlb for review

@allcontributors
Copy link
Contributor

@VeckoTheGecko

I've put up a pull request to add @thanks! 🎉

I've put up a pull request to add @dmlb! 🎉

@VeckoTheGecko
Copy link
Collaborator Author

I've put up a pull request to add @thanks! 🎉

What the heck

@VeckoTheGecko VeckoTheGecko merged commit ecc8fd0 into main Aug 21, 2023
3 checks passed
@VeckoTheGecko VeckoTheGecko deleted the linkcheck branch August 21, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improved resource (and general) linkchecking
2 participants