-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved linkchecking #324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiline strings in variables are handled differently in GHA as per https://stackoverflow.com/a/74232400
This is cool :D |
dmlb
reviewed
Aug 20, 2023
dmlb
approved these changes
Aug 20, 2023
VeckoTheGecko
force-pushed
the
linkcheck
branch
from
August 21, 2023 02:09
6b5c3f7
to
fd86507
Compare
I thought so too 😁 . Really nice way to manage the links. Thanks for the review @dmlb ! @all-contributors please add @dmlb for review |
This was referenced Aug 21, 2023
I've put up a pull request to add @thanks! 🎉 I've put up a pull request to add @dmlb! 🎉 |
What the heck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added Lychee linkchecking action workflow to the repo to go through repo files looking for broken links (404s etc). The workflow:
Issue #322 in this case acts as the main mechanism for surfacing these broken links, in a way that is minimally intrusive (doesn't mess with GHA failures) and interested parties can subscribe to the issue.
Related issue number/link
Fixes #319