Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean and update packages #406

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jattiman
Copy link
Contributor

Describe your changes

  • Deletes yarn.lock in favor of preexisting package-lock.json
    • Since npm is the package manager referred to in the project documentation (yarn is not mentioned), I believe this is the best route to take.
  • Updates packages to address security vulns.
    • Ran npm update to do this. Only 3 moderate vulns should exist now.
    • npm run dev successfully runs project locally after the update.

Note for testers

  • the npm run build command doesn't currently work
    • Error output relates to the lack of a csv file's presence

      NotFound [Error]: Not found: /knowledge-hub/ClimateTown-Knowledge-Hub-resources.csv

    • This same error would also produce itself with a yarn build command on the current main branch. I think it's a separate issue from this PR, but wanted testers to be made aware.

  • I can't get the dev container to work (hence why I'm running the project locally). I also think this is a separate issue from this PR, but wanted testers to be aware.

Related issue number/link

No open issues are resolved with this PR. It's more of a package refactoring to help ensure that the same build process is followed moving forward.

Removed yarn.lock in favor of pre-existing package-lock. Updates packages to address sec vulns.
@VeckoTheGecko
Copy link
Collaborator

Thanks for the PR @jattiman !

  • the npm run build command doesn't currently work

This command should only be run in CI as it's to create the production build. For development run npm run dev (mentioned in readme :) )

Hmm, weird the codespaces isn't working. I'll make an issue

@VeckoTheGecko
Copy link
Collaborator

@all-contributors please add @jattiman for code

Copy link
Contributor

@VeckoTheGecko

I've put up a pull request to add @jattiman! 🎉

@VeckoTheGecko VeckoTheGecko merged commit f5a7cf6 into ClimateTown:main Sep 25, 2024
5 checks passed
@jattiman jattiman deleted the ja/chore/package-cleanup branch September 25, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants