Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry support,fix workflows, update python #45

Merged
merged 15 commits into from
Dec 5, 2023
Merged

Poetry support,fix workflows, update python #45

merged 15 commits into from
Dec 5, 2023

Conversation

ChrOertlin
Copy link
Collaborator

@ChrOertlin ChrOertlin commented Dec 4, 2023 •
edited
Loading

Added

Adds poetry to manage package dependencies, also locks pydantic to version 1.
A migration to pydantic version 2 is required

Fixes workflows that were broken

updates to python 3.11

removes pypi flow

Fixes broken test
removes a broken test

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin changed the title Poetry support Poetry support,fix workflows, update python Dec 4, 2023
@ChrOertlin
Copy link
Collaborator Author

Ignoring the linting for now! Will be a separate PR

seallard
seallard approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@seallard seallard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alt Text

requirements.txt Show resolved Hide resolved
@clingen-sthlm clingen-sthlm temporarily deployed to stage December 4, 2023 15:09 Inactive
@clingen-sthlm clingen-sthlm temporarily deployed to stage December 5, 2023 07:53 Inactive
@ChrOertlin ChrOertlin merged commit 97a095c into master Dec 5, 2023
2 checks passed
@ChrOertlin ChrOertlin deleted the add-poetry-support branch December 5, 2023 08:45
@ChrOertlin ChrOertlin mentioned this pull request Dec 5, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seallard seallard seallard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrOertlin @seallard @clingen-sthlm