Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(steps) #53

Merged
merged 2 commits into from
Dec 8, 2023
Merged

refactor(steps) #53

merged 2 commits into from
Dec 8, 2023

Conversation

ChrOertlin
Copy link
Collaborator

Added

Add tests for step create and get. Also some refactoring.
Will leave the queries alone for now. As i'd like to have a database connection going to better understand what is being retrieved etc.

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@ChrOertlin ChrOertlin requested a review from a team as a code owner December 8, 2023 11:38
diitaz93
diitaz93 approved these changes Dec 8, 2023
View reviewed changes
Copy link

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎅

tests/crud/test_step.py Show resolved Hide resolved
@clingen-sthlm clingen-sthlm temporarily deployed to stage December 8, 2023 12:29 Inactive
@ChrOertlin
Copy link
Collaborator Author

tested by adding steps via lims-stage

@ChrOertlin ChrOertlin merged commit ad8d6c4 into master Dec 8, 2023
2 checks passed
@ChrOertlin ChrOertlin deleted the refactor_step branch December 8, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diitaz93 diitaz93 diitaz93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrOertlin @diitaz93 @clingen-sthlm