Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch aliquot volumes EPP for 0 ul volumes #551

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

Karl-Svard
Copy link
Collaborator

Fixed

  • No longer count 0 ul volumes as being too low

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard Karl-Svard marked this pull request as ready for review October 17, 2024 08:52
@Karl-Svard
Copy link
Collaborator Author

Worked on stage:
Screenshot 2024-10-17 at 10 54 06

@Karl-Svard
Copy link
Collaborator Author

Question: Does it really make sense that 0 ul volumes are allowed for sample aliquots? :P

@AbiDalby
Copy link

AbiDalby commented Oct 17, 2024

That is a really good point, I don't think that should ever happen, but we most certainly wouldn't want to miss it if a sample is so highly concentrated the calculation has calculated sample volume at 0.004 or something.

@idalindegaard
Copy link
Contributor

Could you make it possible for only the buffer to be 0 ul? but not the sample volume

@Karl-Svard
Copy link
Collaborator Author

Yes, that won't be a problem. I'll add that logic!

@Karl-Svard
Copy link
Collaborator Author

New behaviour:

Screenshot 2024-10-17 at 14 29 24

@Karl-Svard
Copy link
Collaborator Author

Ready for review! @AbiDalby @idalindegaard

Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Karl-Svard Karl-Svard merged commit e40767d into master Oct 17, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the patch_aliq_vol branch October 17, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants