-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch aliquot volumes EPP for 0 ul volumes #551
Conversation
Question: Does it really make sense that 0 ul volumes are allowed for sample aliquots? :P |
That is a really good point, I don't think that should ever happen, but we most certainly wouldn't want to miss it if a sample is so highly concentrated the calculation has calculated sample volume at 0.004 or something. |
Could you make it possible for only the buffer to be 0 ul? but not the sample volume |
Yes, that won't be a problem. I'll add that logic! |
Ready for review! @AbiDalby @idalindegaard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Fixed
Steps to consider while deploying
Review:
This version is a: