Add tabs for challenges #4385
Add tabs for challenges #4385
Conversation
tabs_for_challenge.mp4 |
| @@ -1,6 +1,30 @@ | |||
| <section class="ev-sm-container ev-view challenge-container"> | |||
| <p class="text-med-black fs-30 no-margin">All Challenges</p> | |||
| <!-- tabs for challenges --> | |||
There was a problem hiding this comment.
When you are on the ongoing challenge tab, the api for all the challenges will be called. Modify it, so that the challenges relevant to the tab are shown
There was a problem hiding this comment.
@gautamjajoo I think it's necessary to call all the api's so that we can show the number of challenges in each tab. I implemented the approach of calling the api for one specific tab considering it as default tab, whenever the page is loaded for the first time and then call api when we switch tabs. However, the problem is that if I only call the api for default tab, it won't show me the number of challenges on the other tabs.
There was a problem hiding this comment.
@gchhablani Should we display the number of challenges on the tabs? This is a tradeoff between UI vs loading time
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4385 +/- ##
==========================================
- Coverage 72.93% 69.28% -3.65%
==========================================
Files 83 20 -63
Lines 5368 3572 -1796
==========================================
- Hits 3915 2475 -1440
+ Misses 1453 1097 -356
... and 64 files with indirect coverage changes
... and 64 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
No description provided.