Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #185

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Main #185

wants to merge 11 commits into from

Conversation

sjstoelting
Copy link

Hi all,
I switched the naming to primary and secondary in documentations, comments, and log messages to get rid of the abusing terms.

This has to be done for some variables, too. But that will require more work and, obviously, more testing.

Just to let you know, I am using "main" in all my projects instead of the abusing term.

Regards,
Stefanie

@ioguix
Copy link
Member

ioguix commented Jan 12, 2021

Hi,

I already did a first round some week/month ago, mainly on the website part and kept the code part for later. So this help is greatly appreciated, thanks!

I'll review soon.

@ioguix ioguix self-assigned this Jan 12, 2021
@sjstoelting
Copy link
Author

HI,
Thanks for the appreciation ;)
I did not change variable names in the comments, because I thought, that should be part of a variable change.

Just to let you know.

@ioguix
Copy link
Member

ioguix commented Jan 28, 2021

So I had a closer look. Most of the changes are straight forward, but some are not.

The Pacemaker project tries itself to improve its wording using promotable clones and promotion scores, but some keywords are still remaining here and there in conf, variables or commands on their side: https://www.clusterlabs.org/pacemaker/doc/en-US/Pacemaker/2.0/html/Pacemaker_Explained/s-resource-promotable.html

I pushed a commit to your branch to fix various technical wording and one bug related to the recover_master cluster attribute.

I would like to hold a bit more this PR to review it again before merging, with fresh eyes.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants