Fixed a problem with _get_master_score failing in pacemaker-2.1.0 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the node_arg parameter was omitted
|
Hi, As reported in #194, this is not the (only?) root case of the issue. I'm waiting for some more investigation before we can settle an appropriate fix. Thanks for your help, stay tuned! Regards, |
|
We discussed the Upstream is taking care of both bugs ( I'll keep this PR open if you don't mind. I might push some commits on this branch before merging. Thanks |
kgaillot
reviewed
Jan 5, 2023
| @@ -359,7 +359,7 @@ sub _get_master_score { | |||
|
|
|||
| $node_arg = sprintf '--node "%s"', $node if defined $node and $node ne ''; | |||
|
|
|||
| $score = qx{ $CRM_MASTER --quiet --get-value $node_arg 2> /dev/null }; | |||
| $score = qx{ $CRM_MASTER --quiet --query $node_arg 2> /dev/null }; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pacemaker-2.1.0, the
--get-valueoption of the crm_master command now fails if no argument is passed.This has caused the problem in issue #194.
In this PR, the problem is solved by using the
--queryoption instead of the--get-valueoption.