Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print detailed client version in the log #568

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

SadPencil
Copy link
Member

@SadPencil SadPencil commented Oct 4, 2024

This PR prints detailed client version ("ProductVersion") in the log, for example, 2.12.0-feat-detailed-client-version.1+9.Branch.feat-detailed-client-version.Sha.54da550909971152332380ca79fe1b732501ec3a. Containing the git commit should be extremely helpful to minimize the mess and determine the client version if a user uses a non-release build.

@SadPencil SadPencil added this to the 2.11.2.0 milestone Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Nightly build for this pull request:

Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe we should keep both simple version and detailed version?

Also we really should introduce separation between non-released version and released version. Can be as little as a different message in the UI indicating detailed info.

@SadPencil SadPencil merged commit b7f6575 into CnCNet:develop Nov 4, 2024
3 checks passed
@SadPencil SadPencil deleted the feat-detailed-client-version branch November 4, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants