Authentication implementation. #321

sadcenter · 2022-01-08T23:15:37Z

Description

Changes auth implementation from yggdrasil one to mine one. (toggleable in configuration)
It uses https://github.com/Electroid/mojang-api and caches the player's texture to the file.

Fixes/Adds #127 (Not completely due it's impossible, more info in Additional comments section.)

How has this been tested?

Tested by generating skulls and toggling online-mode

Additional Comments

It's impossible to remove the delay completely in async action (sync would be even worse). However, we can try to reduce the delay by using better API, cache, etc.
Default cache time is 1 day.
If there's something wrong with changes, let me know.

Checklist:

I have reviewed my code thoroughly.
I have tested my code. (I recommend testing it again, it's a big update so I might have skipped something)
My changes generate no new warnings

… clean-up

…ize, Code clean-up

ghost

Looks good! This is just a brief review, I'll do a full review and test when I can. Also you should try to not edit the formatting of the files, I see that there's a lot of files with just formatting changes.

NachoSpigot-Server/src/main/java/me/elier/nachospigot/config/NachoConfig.java

NachoSpigot-Server/src/main/java/net/minecraft/server/DedicatedServer.java

NachoSpigot-Server/src/main/java/net/minecraft/server/ItemSkull.java

NachoSpigot-Server/src/main/java/net/minecraft/server/MinecraftServer.java

NachoSpigot-Server/src/main/java/net/minecraft/server/TileEntitySkull.java

NachoSpigot-Server/src/main/java/org/bukkit/craftbukkit/inventory/CraftMetaSkull.java

Blyrex · 2022-01-10T18:43:13Z

its not a good idea to use private apis in this project

NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/utils/ProfileUtil.java

NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/NachoAuthenticatorService.java

NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/utils/HashMapBuilder.java

NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/session/NachoSessionService.java

NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/storage/ProfileCache.java

NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/session/NachoSessionService.java

…etion

sadcenter · 2022-01-18T11:53:06Z

its not a good idea to use private apis in this project

I personally trust this API. I haven't ever met with a situation when this API is down (I'm using this in every project that needs data from Mojang). But not everyone has to trust it, that's why I added an option in the configuration to disable that.
IMO it would be great to add an option that allows you to toggle between ashcon API and Mojang's API

ytnoos · 2022-01-19T05:25:10Z

its not a good idea to use private apis in this project

I personally trust this API. I haven't ever met with a situation when this API is down (I'm using this in every project that needs data from Mojang). But not everyone has to trust it, that's why I added an option in the configuration to disable that.

IMO it would be great to add an option that allows you to toggle between ashcon API and Mojang's API

I think it would be good to automatically switch to Mojang's API if any exception is caught with ashcon API

CyberFlameGO · 2022-01-19T11:26:21Z

its not a good idea to use private apis in this project

The API seems open source (as declared on the issue init message) and claims to be hosted on Cloudflare Workers

CyberFlameGO · 2022-01-19T11:28:58Z

Oh also the person running and maintaining the API works at Cloudflare

NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/NachoAuthenticationService.java

NachoSpigot-Server/src/main/java/me/elier/nachospigot/config/NachoConfig.java

ghost · 2022-01-19T22:04:47Z

NachoSpigot-Server/src/main/java/me/elier/nachospigot/config/NachoConfig.java

+    public static boolean alwaysUseMojang;
+
+    private static void alwaysUseMojang() {
+        alwaysUseMojang = getBoolean("settings.authenticator.always-use-mojang", true);


Imo this should be inverted and be use-ashcon-api

Sculas · 2022-01-19T23:00:52Z

Looks good! Awesome PR :)
Since some reviews are not yet resolved, I'll wait until this is fully ready. Since I do not look at this repo often because I don't have much time, please ping me if possible so I can merge it :)

… clean-up

…ize, Code clean-up

…etion

# Conflicts: # NachoSpigot-API/pom.xml # NachoSpigot-Server/pom.xml # NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/NachoAuthenticationService.java # NachoSpigot-Server/src/main/java/com/github/sadcenter/auth/profile/NachoGameProfileRepository.java # NachoSpigot-Server/src/main/java/me/elier/nachospigot/config/NachoConfig.java

sadcenter · 2022-01-20T00:25:08Z

oops Intelij IDEA kinda messed up I believe

ghost · 2022-01-20T00:29:29Z

oops Intelij IDEA kinda messed up I believe

Rebasing on master should partially fix it

ghost · 2022-01-21T21:05:04Z

NachoSpigot-Server/src/main/java/me/elier/nachospigot/config/NachoConfig.java

+        backups = getBoolean("settings.authenticator.backups", true);
+        uuidMojangPriority = getString("settings.authenticator.uuid-priority", "ashcon")
+                .equalsIgnoreCase("ashcon");
+        texturesMojangPriority = getString("settings.authenticator.textures-priority", "mojang")


We should use ~~integers~~ booleans to specify the api

Sculas · 2022-02-15T00:04:06Z

Is this PR stale or not?

HowardZHY · 2022-02-20T16:19:19Z

is #353 related to this?

sadcenter · 2022-02-20T21:03:34Z

is #353 related to this?

it might fix it, but it's unlikely possible since authlib wasn't touched in nacho

sadcenter · 2022-02-20T21:05:37Z

Is this PR stale or not?

yea, I will resolve the conflicts tomorrow (if tram won't hit me or smth)

sadcenter · 2022-02-23T10:34:11Z

CodeQL uses Java 11 where exceptionallyCompose and exceptionallyComposeAsync doesn't exist :/

sadcenter added 13 commits January 3, 2022 14:14

auth

bf45491

auth

ffe3898

auth skull

8e7d64f

Improvements, Ignore case in map, 1 save/tick, fixed code-style, code…

a18ed72

… clean-up

Improvements, Ignore case in map, 1 save/tick, fixed code-style, code…

a777e51

… clean-up

Improvements, UUID storage deletion, Add config support, Import optim…

c352589

…ize, Code clean-up

Code style fixes

f37d76e

Removes useless abstract types

2632d90

Package name change

70946b2

Cache storage fix.

8c528c7

final commit

312c0a7

method rename

d4e2b9b

useless async deletion

6513ee1

ghost reviewed Jan 8, 2022

View reviewed changes

comments fix

a8e01fe

ghost approved these changes Jan 10, 2022

View reviewed changes

ghost suggested changes Jan 16, 2022

View reviewed changes

Optimize imports, name changes, exception logging & useless utils del…

af1db4e

…etion

ghost approved these changes Jan 18, 2022

View reviewed changes

ghost approved these changes Jan 19, 2022

View reviewed changes

sadcenter marked this pull request as draft January 19, 2022 13:00

minor code style fixes, using mojang api if ashcon's api fails

fbfe538

sadcenter marked this pull request as ready for review January 19, 2022 20:42

ghost suggested changes Jan 19, 2022

View reviewed changes

sadcenter added 18 commits January 20, 2022 01:21

auth

c0cb883

auth

a35e135

auth skull

453bbce

Improvements, Ignore case in map, 1 save/tick, fixed code-style, code…

278ac2c

… clean-up

Improvements, Ignore case in map, 1 save/tick, fixed code-style, code…

976e51b

… clean-up

Improvements, UUID storage deletion, Add config support, Import optim…

61189ca

…ize, Code clean-up

Code style fixes

d78218f

Removes useless abstract types

adb8667

Package name change

acbd54c

Cache storage fix.

8f6ef1a

final commit

729cd4e

method rename

6eb2219

useless async deletion

bfe289f

comments fix

94f022d

Optimize imports, name changes, exception logging & useless utils del…

70e5743

…etion

minor code style fixes, using mojang api if ashcon's api fails

b006697

conflict resolved, config features

ac984c2

sadcenter marked this pull request as draft January 20, 2022 00:34

ghost reviewed Jan 21, 2022

View reviewed changes

sadcenter and others added 2 commits February 23, 2022 11:14

Merge branch 'master' into auth-v2

f837b67

duh

6b46a29

sadcenter marked this pull request as ready for review March 2, 2022 20:02

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Authentication implementation. #321

Authentication implementation. #321

sadcenter commented Jan 8, 2022

ghost left a comment

Blyrex commented Jan 10, 2022

sadcenter commented Jan 18, 2022

ytnoos commented Jan 19, 2022

CyberFlameGO commented Jan 19, 2022

CyberFlameGO commented Jan 19, 2022

ghost Jan 19, 2022

Sculas commented Jan 19, 2022

sadcenter commented Jan 20, 2022

ghost commented Jan 20, 2022 •

edited by ghost

Loading

ghost Jan 21, 2022 •

edited by ghost

Loading

Sculas commented Feb 15, 2022

HowardZHY commented Feb 20, 2022

sadcenter commented Feb 20, 2022 •

edited

Loading

sadcenter commented Feb 20, 2022

sadcenter commented Feb 23, 2022

Authentication implementation. #321

Authentication implementation. #321

Conversation

sadcenter commented Jan 8, 2022

Description

How has this been tested?

Additional Comments

Checklist:

ghost left a comment

Choose a reason for hiding this comment

Blyrex commented Jan 10, 2022

sadcenter commented Jan 18, 2022

ytnoos commented Jan 19, 2022

CyberFlameGO commented Jan 19, 2022

CyberFlameGO commented Jan 19, 2022

ghost Jan 19, 2022

Choose a reason for hiding this comment

Sculas commented Jan 19, 2022

sadcenter commented Jan 20, 2022

ghost commented Jan 20, 2022 • edited by ghost Loading

ghost Jan 21, 2022 • edited by ghost Loading

Choose a reason for hiding this comment

Sculas commented Feb 15, 2022

HowardZHY commented Feb 20, 2022

sadcenter commented Feb 20, 2022 • edited Loading

sadcenter commented Feb 20, 2022

sadcenter commented Feb 23, 2022

ghost commented Jan 20, 2022 •

edited by ghost

Loading

ghost Jan 21, 2022 •

edited by ghost

Loading

sadcenter commented Feb 20, 2022 •

edited

Loading