Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved default settings #707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved default settings #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions dexbot/strategies/config_parts/relative_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,38 +32,38 @@ def configure(cls, return_base_config=True):
'Use external reference price instead of center price acquired from the market', None),
ConfigElement('external_price_source', 'choice', EXCHANGES[0][0], 'External price source',
'The bot will try to get price information from this source', EXCHANGES),
ConfigElement('amount', 'float', 1, 'Amount',
ConfigElement('amount', 'float', 4.5, 'Amount',
'Fixed order size, expressed in quote asset, unless "relative order size" selected',
(0, None, 8, '')),
ConfigElement('relative_order_size', 'bool', False, 'Relative order size',
ConfigElement('relative_order_size', 'bool', True, 'Relative order size',
'Amount is expressed as a percentage of the account balance of quote/base asset', None),
ConfigElement('spread', 'float', 5, 'Spread',
'The percentage difference between buy and sell', (0, 100, 2, '%')),
ConfigElement('dynamic_spread', 'bool', False, 'Dynamic spread',
'Enable dynamic spread which overrides the spread field', None),
ConfigElement('market_depth_amount', 'float', 0, 'Market depth',
ConfigElement('market_depth_amount', 'float', 99, 'Market depth',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be 99 as different assets have different value. Better keep 0 here.

'From which depth will market spread be measured? (QUOTE amount)',
(0.00000001, 1000000000, 8, '')),
ConfigElement('dynamic_spread_factor', 'float', 1, 'Dynamic spread factor',
ConfigElement('dynamic_spread_factor', 'float', 80, 'Dynamic spread factor',
'How many percent will own spread be compared to market spread?',
(0.01, 1000, 2, '%')),
ConfigElement('center_price', 'float', 0, 'Center price',
'Fixed center price expressed in base asset: base/quote', (0, None, 8, '')),
ConfigElement('center_price_dynamic', 'bool', True, 'Measure center price from market orders',
'Estimate the center from closest opposite orders or from a depth', None),
ConfigElement('center_price_depth', 'float', 0, 'Measurement depth',
ConfigElement('center_price_depth', 'float', 999, 'Measurement depth',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, keep 0 here.

'Cumulative quote amount from which depth center price will be measured',
(0.00000001, 1000000000, 8, '')),
ConfigElement('center_price_from_last_trade', 'bool', False, 'Last trade price as new center price',
'This will make orders move by half the spread at every fill', None),
ConfigElement('center_price_offset', 'bool', False, 'Center price offset based on asset balances',
ConfigElement('center_price_offset', 'bool', True, 'Center price offset based on asset balances',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to leave this to the user.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to leave this to the users with 'true', because false makes no sense for RO strategy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really depends on how it's being used.

'Automatically adjust orders up or down based on the imbalance of your assets', None),
ConfigElement('manual_offset', 'float', 0, 'Manual center price offset',
"Manually adjust orders up or down. "
"Works independently of other offsets and doesn't override them", (-50, 100, 2, '%')),
ConfigElement('reset_on_partial_fill', 'bool', True, 'Reset orders on partial fill',
'Reset orders when buy or sell order is partially filled', None),
ConfigElement('partial_fill_threshold', 'float', 30, 'Fill threshold',
ConfigElement('partial_fill_threshold', 'float', 80, 'Fill threshold',
'Order fill threshold to reset orders', (0, 100, 2, '%')),
ConfigElement('reset_on_price_change', 'bool', False, 'Reset orders on center price change',
'Reset orders when center price is changed more than threshold '
Expand Down