-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Docs #18
base: master
Are you sure you want to change the base?
Restructure Docs #18
Conversation
Please talk with me about changes before just making them. Thanks.
My apologies. I thought I tried to submit a review, not a commit... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
70% Grammer, 30% Changes
Co-authored-by: Gregory Mitchell <[email protected]>
Co-authored-by: Gregory Mitchell <[email protected]>
Didn't edit everything else, only added the missing content from the Information was borrowed from official documentation. BitBucket isn't implemented yet until @sgdc3 installs the BitBucket plugin. Feel free to directly change the files. |
@gmitch215 bitbucket integration installed 👍 |
I've now set up redirects for the old pages under the One thing that is still left is updating the commit/build status integration for GitHub, as that one uses info that by the looks of it do no longer work with the current Jenkins implementation of CodeMC. I sadly don't know what the current/new aproach would be, if there still is one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @sgdc3 has nothing else, LGTM
Made some final changes on my ends now. Namely I added the git-revision-date-localized and the git-committers plugins to use. I also updated the GitHub Actions Workflow to now use a direct deployment to GitHub pages which is usually faster and better to do. It will require to save the custom subdomain again in the repo settings so GitHub is aware of it being used as the CNAME file has no usage here using this aproach. |
Co-authored-by: Gregory Mitchell <[email protected]>
Deploying documentation with Cloudflare Pages
|
Update docs/services/ci/setups/gradle-job.md
Restructures the current documentation.
Things left to do: