-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "all projects" button to navigation bar and in-page navigation to event page #354
Conversation
Also added a sidebar in-page navigation to event show template using anchors and Foundation classes. Links only show up if the sections they lead to exist. Issue #342 |
@rachelmad - Great meeting you on Saturday! Thank you for making these changes 👏 🎉 Because the in-page navigation is so design focused - and really not related to the previous work - I would like to review these changes as two separate pull requests (PRs). I'll take care of the "All Projects" work you did before the week is out, but I would love for you to make the in-page navigation PR yourself, if you have time, since you seemed so excited about git on Saturday. If you're not interested in making this change, just comment and let me know. Otherwise, here's some deets on how to make it happen: You'll want to:
Here's some details about Thanks again!! |
Hi Courteney, It was nice to meet you too! I'd love to do this! I'll work on it one of these upcoming weekends :) On Thu, Mar 5, 2015 at 11:26 AM Courteney [email protected] wrote:
|
@rachelmad - I thought I'd be able to separate out the first portion of this change (the "All Projects" link) without removing your name, but it looks like it's not going to be possible. I want you to get credit for your work, so I'd love it if you could now separate out both commits into separate branches and make new PRs for them. The steps should be very similar to the ones I shared before, but for the other commit. We'd love to have this fixed before an event we're hosting on 3/19, so if it's possible for you to work on it this weekend, that would be ideal. Otherwise, I'll split it up next Friday. (If that happens, you'll still have your name on the commit itself - no worries!) |
@rachelmad - You rock! 👏 👏 The new PRs look great. Thanks for getting to them over the weekend. If you want to work on CodeMontage in the future, you will probably want to set your master branch back to upstream master using Again, thank you! I'm looking forward to getting some of your code into the app. |
Added the "All projects" button when mouse hovers over the Projects text. Leads to the same link as the Project button