Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NW6|Bakhat Begum|HTML_CSS|Bikes-for-refugees| Week 1 #477

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NW6|Bakhat Begum|HTML_CSS|Bikes-for-refugees| Week 1 #477

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
025ae5b
I did changes on website
Sep 23, 2023
131d8e1
i made changes on img alt, color, padding and layout
Sep 27, 2023
f3a3709
I added changas according to comment on Github
Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
298 changes: 152 additions & 146 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,160 +20,166 @@
</head>

<body>
<div class="header">
<header class="header">
<a href="#">
<img
src="images/bikes-for-refugees_logo.jpg"
alt="Logo for Bikes for Refugees Scotland"
class="header__logo"
/>
</a>

<nav>
<ul class="navigation__list">
<li class="navigation__item">
<a class="navigation__link" href="#">Home</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">About Us</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">News & Events</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">Contact Us</a>
</li>
</ul>
</nav>

<button>Donate Now</button>
</header>

<content class="content">
<main class="main">
<main class="alert">
You've helped us give <span class="text-highlight">72</span> bikes to
refugees and asylum seekers so far. <strong>Thank you!</strong>
</main>

<figcaption class="hero">
<h1>Bikes for Refugees</h1>
<p>
Providing donated bikes and accessories to refugees and asylum
seekers in Scotland.
</p>
<button>Donate a bike today</button>
<button class="btn">Volunteer</button>
</figcaption>

<article>
<h2 class="heading-underline">Learn more</h2>

<article class="learn-more-articles">
<section class="block">
<h3 class="article__title">Why do refugees need bikes?</h3>
<p class="article__summary">
Many refugees are placed in housing in areas where there are few
jobs. Bikes provide low-cost transportation so that they can get
to work, manage child care and do their shopping.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</section>

<section class="block">
<h3 class="article__title">How can I help?</h3>
<p class="article__summary">
We need lots of bikes and bike accessories! If you have an old
bike you don't use, bring it to one of our dropoff events. Or
come attend one of our fundraisers.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</section>
</article>
</article>
</main>

<article class="sidebar">
<h2 class="heading-underline">Upcoming events</h2>

<a href="#">
<aside class="article">
<img
src="images/bikes-for-refugees_logo.jpg"
alt="Logo for Bikes for Refugees Scotland"
class="header__logo"
class="article__thumbnail"
src="images/spring-fundraisers_thumbnail.jpg"
alt=""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no alt tag here!
Also, have a look at your page and the page given. Does yours look the same? Try playing around with the padding of this element in the CSS!

/>
</a>

<div>
<ul class="navigation__list">
<li class="navigation__item">
<a class="navigation__link" href="#">Home</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">About Us</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">News & Events</a>
</li>
<li class="navigation__item">
<a class="navigation__link" href="#">Contact Us</a>
</li>
</ul>
</div>

<button>Donate Now</button>

</div>

<div class="content">
<div class="main">
<div class="alert">
You've helped us give <span class="text-highlight">72</span> bikes
to refugees and asylum seekers so far. <strong>Thank you!</strong>
</div>

<div class="hero">
<h1>Bikes for Refugees</h1>
<p>
Providing donated bikes and accessories to refugees and asylum
seekers in Scotland.
<figcaption class="article__content">
<h3 class="article__title">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at the image provided to you. Your title looks a bit squashed to the top. How would you fix that? Maybe with some padding?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Eliza, I committed all those mistakes that you mentioned.

<a class="article__title-link" href="#"
>Join us for our Spring fundraisers</a
>
</h3>
<p class="article__summary">
Riders needed now to help raise awareness and funds for BfR and
Médecins Sans Frontières.
</p>
<button>Donate a bike today</button>
<button>Volunteer</button>
</div>

<div>
<h2 class="heading-underline">Learn more</h2>

<div>
<div class="article">
<h3 class="article__title">Why do refugees need bikes?</h3>
<p class="article__summary">
Many refugees are placed in housing in areas where there are
few jobs. Bikes provide low-cost transportation so that they
can get to work, manage child care and do their shopping.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</div>

<div class="article">
<h3 class="article__title">How can I help?</h3>
<p class="article__summary">
We need lots of bikes and bike accessories! If you have an
old bike you don't use, bring it to one of our dropoff
events. Or come attend one of our fundraisers.
</p>
<p class="article__read-more">
<a href="#">
<span class="arrow-right"></span>
Learn more
</a>
</p>
</div>
</div>
</div>
</div>

<div class="sidebar">
<h2 class="heading-underline">Upcoming events</h2>

<div class="article">
<img
class="article__thumbnail"
src="spring-fundraisers_thumbnail.jpg"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Join us for our Spring fundraisers</a>
</h3>
<p class="article__summary">
Riders needed now to help raise awareness and funds for BfR and
Médecins Sans Frontières.
</p>
</div>
</div>

<div class="article">
<img
class="article__thumbnail"
src="bikes-for-refugees_logo.jpg"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Bike dropoff event in Edinburgh on May 11</a>
</h3>
</div>
</div>

<div class="article">
<img
class="article__thumbnail"
src="edinburgh-damascus_thumbnail.png"
alt=""
/>
<div class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Help us cycle 4,797km</a>
</h3>
<p class="article__summary">
We need you to help us cycle 4797km, the distance of Edinburgh
to Damascus.
</p>
</div>
</div>
</figcaption>
</aside>

<a
href="https://www.facebook.com/BikesforRefugeesScotland/events/?ref=page_internal"
target="_blank"
class="facebook-link"
>
<span class="fa fa-facebook-square"></span>
All Facebook events
</a>
</div>
</div>

<div class="footer">
<div class="footer__content">
<aside class="article">
<img
class="article__thumbnail"
src="images/bikes-for-refugees_logo.jpg"
alt="bikes image"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to say "image" in the alt tag. The alt tag is made specifically to describe images, so adding the word image is unnecessary. It's important to keep the information as concise but descriptive as possible here!

/>
<figcaption class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#"
>Bike dropoff event in Edinburgh on May 11</a
>
</h3>
</figcaption>
</aside>

<aside class="article">
<img
class="article__thumbnail"
src="images/edinburgh-damascus_thumbnail.png"
alt="image for Help us cycle 4,797km"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same "image" comment as up there ^

/>
<figcaption class="article__content">
<h3 class="article__title">
<a class="article__title-link" href="#">Help us cycle 4,797km</a>
</h3>
<p class="article__summary">
We need you to help us cycle 4797km, the distance of Edinburgh to
Damascus.
</p>
</figcaption>
</aside>

<a
href="https://www.facebook.com/BikesforRefugeesScotland/events/?ref=page_internal"
target="_blank"
class="facebook-link"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the class "facebook-link"
Have a look at the sample image vs your website. Yours is to the left whilst theirs is to the right. How could you change that? Try adding display:flex to this class in css and play around with the grid inspector in dev tools to figure out what else you have to add!

>
<span class="fa fa-facebook-square"></span>
All Facebook events
</a>
</article>
</content>

<footer class="footer">
<content class="footer__content">
<p>
<strong>Bikes for Refugees Scotland is a volunteer-led project to help
people explore and make connections with their local communities.</strong>
<strong
>Bikes for Refugees Scotland is a volunteer-led project to help
people explore and make connections with their local
communities.</strong
>
</p>
<p>Website by Code Your Future</p>
</div>
</div>
</content>
</footer>
</body>
</html>
Loading