Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 340 (snomed preprocessing) #343

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Aug 29, 2023

Add missing self argument for method

Fix for #340

@mart-r mart-r requested a review from antsh3k August 29, 2023 09:40
@antsh3k
Copy link
Collaborator

antsh3k commented Aug 29, 2023

This should fix it. Thanks.

Copy link
Collaborator

@antsh3k antsh3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r
Copy link
Collaborator Author

mart-r commented Aug 29, 2023

Just a note that the GHA failure is waiting on #342

EDIT:
Just for clarity, I'll wait for the GHA failure fix to be merged in, and then rerun GHA on this branch before merging.

@mart-r mart-r merged commit 54d8a6d into CogStack:master Sep 4, 2023
5 checks passed
@mart-r mart-r deleted the issue340Hotfix_preprocess_snomed branch September 8, 2023 08:38
mart-r added a commit that referenced this pull request Sep 21, 2023
* remove bad merge <p> element

* CU-8692kpchc Fix for Rosalind link not working (#342)

* CU-8692kpchc Add the 403 exception to vocab downloader

* CU-8692kpchc Add the new vocab download link

* Add missing self argument (#343)

To `_refset_df2dict ` method in Snomed preprocessing

* CU-8692kn0yv Fix issue with fake dict in identifier based config

More specifically the get method which was not able to return default values for non-existant keys (#341)

* CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method (#345)

* CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method

* CU-8692mevx8 Fix filter retention in train_supervised method

---------

Co-authored-by: tomolopolis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants