-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CU-8695hghww backwards compatibility workflow #478
base: master
Are you sure you want to change the base?
Conversation
Task linked: CU-8695hghww Add model compatibility workflow |
Updates the zip in S3 bucket to include 1.13 built model pack. Reran the latest GHA workflow to run it through that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does this mean each future release of MedCAT will request a new fake model be created and uploaded to S3? Is this part of the standard release process?
There is currently nothing in the release documentation to do this. With that said, adding a compulsory step for this could complicate the release process. After all, whoever is doing the release would need to download the existing models, unzip, create a new model with the new release, upload back on to S3. |
Yes, documentation will help. Also, some automation could be done as part of the release workflow, ref. configure-aws-credentials. |
Add a new step to GHA workflow that does the following:
This PR depends on #470 and the GHA workflow will fail without it having been merged in since some of the necessary parts don't exist or are in a different state.
NOTE:
Perhaps I'd want to include some (basic) legacy DeID models as well to make sure that works?