Presenter Console #10107

hcvcastro · 2024-09-24T14:55:45Z

browser: slideshow: simplify notify blocked popup
browser: slideshow: simplify 'onSlideShowInfo'
browser: slideshow: add options parameter to SlideShowPresenter
browser: slideshow: add options parameters to not start presentation
browser: slideshow: change to public '_startSlide' access
browser: slideshow: add 'PresenterConsole' class
browser: slideshow: avoid unhandled excpetions requestedSlideHash

browser/src/slideshow/SlideShowPresenter.ts

browser/src/slideshow/engine/animationnodes/AnimationBaseNode.ts

browser/src/slideshow/engine/MetaSlide.ts

browser/src/slideshow/SlideShowPresenter.ts

browser/src/slideshow/LayerDrawing.ts

Useful with 2 instances of SlideShowPresenter class. Change-Id: Ibe39c8f907544eca134348d0ac77095cfffb964e Signed-off-by: Henry Castro <[email protected]>

Change-Id: Ibd4017174bd9eff5ffe456847cb3e4287ccaeba2 Signed-off-by: Henry Castro <[email protected]>

Change-Id: I2c7eaacdc397fcb2673323bfeb5b034bab25a169 Signed-off-by: Henry Castro <[email protected]>

Change-Id: Ibb07c214afe2741942e2f81281395077328eab63 Signed-off-by: Henry Castro <[email protected]>

Useful with 2 instances of SlideShowPresenter class Change-Id: I1e0528d05ddfc157350e7aa549223638c2aa24b9 Signed-off-by: Henry Castro <[email protected]>

Useful with 2 instances of SlideShowPresenter class. Change-Id: Ic162190f881e3a32395afd45fa84e8e81fecf084 Signed-off-by: Henry Castro <[email protected]>

Useful with 2 instances of SlideShowPresenter class. Change-Id: I27c301cb7dfdae9034df97eed107a2066cadc84a Signed-off-by: Henry Castro <[email protected]>

Change-Id: I9e07681b3834e35b673e65e126fe751f3060403b Signed-off-by: Henry Castro <[email protected]>

It removes all cached master page layers so the background layer is lost when the start slide is greater than 0. Change-Id: I4ce3b40f80fc6e8f268b6528db501e209ea8dcb3 Signed-off-by: Henry Castro <[email protected]>

If 2 instances are running of the SlideShowPresenter class, they receive 2 notifications about different request slides, which will cause to start slide will not draw. Change-Id: I64b9624c94a99f56da6e6fb195b68cef88d5cf4b Signed-off-by: Henry Castro <[email protected]>

Useful with 2 instances of SlideShowPresenter class. Change-Id: I1fab2dfee0f459ba2a219c042714ec9046045e18 Signed-off-by: Henry Castro <[email protected]>

Change-Id: Iba972196b2f35414e60332f530033e453f54c393 Signed-off-by: Henry Castro <[email protected]>

Change-Id: I1a5bb756860f6b17a08addae7a0d35493868be52 Signed-off-by: Henry Castro <[email protected]>

Change-Id: Ifa5335a5b9e900c600e5c2a23689c045faf94579 Signed-off-by: Henry Castro <[email protected]>

Change-Id: I52b19dc3333a2aac9f63bee27ff0f1f3d477cbfc Signed-off-by: Henry Castro <[email protected]>

Change-Id: Iaa20375c2f5fba8904bb87be7134d87e7ba7e0db Signed-off-by: Henry Castro <[email protected]>

Change-Id: I0efab12d35af66d324205f262c417a1ff1598cdc Signed-off-by: Henry Castro <[email protected]>

Change-Id: I15675368af1e964737d740968e1127bcdbf1282f Signed-off-by: Henry Castro <[email protected]>

Change-Id: I6730127ecd7ac23aae18922037befa2875101ca7 Signed-off-by: Henry Castro <[email protected]>

Change-Id: I6d555b17bc3cc6e92d74379065ff91ff6c47e7db Signed-off-by: Henry Castro <[email protected]>

Change-Id: I25ba37eaf23d324de9ba9c88b26443952ece9c46 Signed-off-by: Henry Castro <[email protected]>

Useful with 2 instances of the SlideShowPresenter class. Change-Id: Ib4c6f6476d8da7209124bd8c6515b6c6038750aa Signed-off-by: Henry Castro <[email protected]>

Useful to fire display slide with 3 instances of the SlideShowPresenter class. Change-Id: Ic039cc4494541ec90dce2a9cbbae74796591b3a7 Signed-off-by: Henry Castro <[email protected]>

2 panes, main presentation and next presentation. Change-Id: Idb7f85ddfe42775233370e3841b0fb1cd865a570 Signed-off-by: Henry Castro <[email protected]>

main presentation and next presentation. Change-Id: Iac28b193adeb398a06a4661af2112f38385423ff Signed-off-by: Henry Castro <[email protected]>

requires https://gerrit.libreoffice.org/c/core/+/174613 Change-Id: I030932470df203de6bf9ec9ef27f34de3d85cbf0 Signed-off-by: Henry Castro <[email protected]>

Change-Id: Ia80caebd89efc139c8d0bd7561047e564a23b919 Signed-off-by: Henry Castro <[email protected]>

Change-Id: I37cffaeb8916390aee25f18d3a92a58e4a0bfc6d Signed-off-by: Henry Castro <[email protected]>

mcecchetti · 2024-10-01T12:32:23Z

browser/src/slideshow/engine/animationnodes/AnimationBaseNode.ts

@@ -81,12 +81,14 @@ abstract class AnimationBaseNode extends BaseNode {
 							slideHash,
 							slideWidth,
 							slideHeight,
+							this.aNodeContext.aContext.aSlideShowHandler.getPresenter()._slideRenderer,


since it'is a long chain it would be more clean to set it in a slideRenderer variable which is used as a parameter in both call

mcecchetti · 2024-10-01T12:52:13Z

browser/src/slideshow/LayerDrawing.ts

+		}
+
+		const layers = this.cachedDrawPages.get(this.requestedSlideHash);
+		if (!layers || layers.length === 0) {


better to reset
this.requestedSlideHash = null;
this.prefetchedSlideHash = null;

mcecchetti · 2024-10-02T07:08:45Z

browser/src/slideshow/PresenterConsole.js

@@ -0,0 +1,113 @@
+/* -*- js-indent-level: 8 -*- */


I'm a bit confused here.
It seems to me that we end up creating 2 instances of animation engine classes, renderer classes so we render and animate the presentation twice which looks expensive. Maybe I've misunderstood the role of the presentation console. Shall you illustrate the design plan.

Oh so now we've 3 slideshow instances running! :-)
I think that's a source of troubles.

mcecchetti · 2024-10-10T10:34:08Z

browser/src/slideshow/StaticTextRenderer.ts

+	}
+
+	public createImageText(displayText: string): ImageBitmap {
+		const width = this._canvasContext.canvas.width;


Nice to have the static text renderer for the 2d case, too. Anyway shall you avoid code duplication btw createImageText and create2DCanvasWithText used in the gl case ?

hcvcastro force-pushed the pr/master/7C branch 4 times, most recently from c675dc4 to 6761537 Compare September 25, 2024 14:44