feat(impress): Allow inserting multimedia #10204
Open
+211
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we could play videos/audio inserted from LibreOffice, but had no way to insert them from online. This commit adds a new "Multimedia" button to the insert menu of impress, which supports inserting different audio/video formats.
This relies on https://gerrit.libreoffice.org/c/core/+/174740 (or to be running inproc in some environments where the sandboxing is weaker) as otherwise it is unable to send the size of the inserted video to core, which will cause core to fail to insert the new element.
Change-Id: I881818277edb69ee1e98ba1bd3454e8d29593889
Summary
TODO
Checklist
make prettier-write
and formatted the code.make check
make run
and manually verified that everything looks okay