Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: accessibility: fix incorrect semantic use of a <table> tag #9457

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
eaf4d90
browser: treeview: initial class TreeViewControl
hcvcastro Jul 10, 2024
b0adfb8
browser: treeview: add simple case table list
hcvcastro Jul 11, 2024
903da49
browser: treeview: add 'fillHeaders' method
hcvcastro Jul 12, 2024
7974619
browser: treeview: add n - 1 level table childs
hcvcastro Jul 12, 2024
b237558
browser: treeview: set roles to table items
hcvcastro Jul 16, 2024
a88d337
browser: treeview: add expander icon
hcvcastro Jul 16, 2024
5746c67
browser: treeview: set 'aria-expanded' attributes
hcvcastro Jul 17, 2024
370541a
browser: treeview: use level 1 as root element
hcvcastro Jul 17, 2024
1ba55e7
browser: treeview: add event listener 'click' expander
hcvcastro Jul 17, 2024
dbe7b9b
browser: treeview: add "toggleExpand" method
hcvcastro Jul 18, 2024
9bd8b7d
browser: treeview: upgrade eslint to 8.0.0
hcvcastro Jul 19, 2024
08b4438
browser: treeview: add select entry method
hcvcastro Jul 19, 2024
2a38548
browser: treeview: add "createImageColumn" method
hcvcastro Jul 22, 2024
6ade550
browser: treeview: add expand/collapse custom icons
hcvcastro Jul 23, 2024
acc0358
browser: treeview: add link cell type
hcvcastro Jul 23, 2024
c05faa6
browser: treeview: add regular cell text
hcvcastro Jul 23, 2024
8a5d4b7
browser: treeview: move 'createSelectionElement' function and deps
hcvcastro Jul 24, 2024
dc6aa9e
browser: treeview: initial class inheritance
hcvcastro Jul 25, 2024
0e1169d
browser: treeview: add FactoryTreeView class
hcvcastro Jul 25, 2024
2878e25
browser: treeview: move fill header/row/cells
hcvcastro Jul 26, 2024
f69ad6a
browser: treeview: move click/select to complex table
hcvcastro Aug 1, 2024
cffb16d
browser: treeview: fix click selection
hcvcastro Aug 2, 2024
fb70d01
browser: treeview: add radio/checkbox to row
hcvcastro Aug 2, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/.eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"browser": true
},
"parserOptions": {
"ecmaVersion": 2017
"ecmaVersion": 2022
},
"overrides": [
{
Expand Down
3 changes: 3 additions & 0 deletions browser/css/jsdialogs.css
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,7 @@ td.jsdialog > [id^='table-box']:not(.sidebar) {

.ui-expander-label::before,
.ui-treeview-expandable.collapsed > .ui-treeview-expander::before,
.ui-treeview tr[aria-expanded='false'] > td:first-child::before,
.ui-treeview tr[aria-expanded='false'] > td > .ui-treeview-expander::before {
display: inline-block;
content: 'V';
Expand All @@ -376,6 +377,7 @@ td.jsdialog > [id^='table-box']:not(.sidebar) {

.ui-expander-label.expanded::before,
.ui-treeview-expandable:not(.collapsed) > .ui-treeview-expander::before,
.ui-treeview tr[aria-expanded='true'] > td:first-child::before,
.ui-treeview tr[aria-expanded='true'] > td > .ui-treeview-expander::before {
content: 'V';
color: transparent;
Expand All @@ -392,6 +394,7 @@ td.jsdialog > [id^='table-box']:not(.sidebar) {
}

.ui-treeview-expandable > .ui-treeview-expander::before,
.ui-treeview tr[aria-expanded] > td:first-child::before,
.ui-treeview tr[aria-expanded] > td > .ui-treeview-expander::before {
margin-inline-end: 7px !important;
display: inline-block;
Expand Down
6 changes: 3 additions & 3 deletions browser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
"@types/node": "14.14.25",
"@types/offscreencanvas": "^2019.7.3",
"@types/w2ui": "^1.4.37",
"@typescript-eslint/eslint-plugin": "^4.21.0",
"@typescript-eslint/parser": "^4.21.0",
"@typescript-eslint/eslint-plugin": "^5.0.0",
"@typescript-eslint/parser": "^5.0.0",
"autolinker": "3.14.1",
"browserify": "16.5.1",
"browserify-css": "0.15.0",
"canvas": "^2.6.1",
"d3": "6.7.0",
"eslint": "7.0.0",
"eslint": "8.0.0",
"eslint-config-prettier": "^9.1.0",
"fzstd": "0.1.0",
"hammerjs": "2.0.8",
Expand Down
Loading
Loading