-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable context menu key #9825
Open
NickWingate
wants to merge
2
commits into
master
Choose a base branch
from
private/nickwingate/enable-contextmenu-key
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enable context menu key #9825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows keyboard navigation of context menu Signed-off-by: NickWingate <[email protected]> Change-Id: I1eeb0afa7447c42f60f86ce42e152ad3d65c6e58
When context menu key is pressed we now send the command to core. Signed-off-by: NickWingate <[email protected]> Change-Id: Ic12c5f3837042556962fb563107d34a6c0c374a6
I think I have found a problem
09:18:58.911 1723792738912 INCOMING: invalidatecursor: { "viewId": "4", "rectangle": "2305, 1418, 0, 276", "mispelledWord": "0", "hyperlink": {} } global.js:529:37
09:18:58.912 Error in parsing value for 'top'. Declaration dropped. cool.html
09:18:59.010 1723792739011 OUTGOING: key type=up char=0 key=1027
global.js:529:37
09:19:00.042 1723792740042 OUTGOING: key type=input char=0 key=1305
global.js:529:37
09:19:00.060 1723792740061 INCOMING: contextmenu: {
"menu": [
{
"text": "~Cut",
"type": "command",
"command": ".uno:Cut",
"enabled": "false"
},
{
"text": "Cop~y",
"type": "command",
<truncated 15771chars> global.js:529:37
09:19:00.065
Exception TypeError: operation is null emitting event contextmenu: {
"menu": [
{
"text": "~Cut",
"type": "command",
"command": ".uno:Cut",
"enabled": "false"
},
{
"text": "Cop~y",
"type": "command",
"command": ".uno:Copy",
"enabled": "false"
},
{
"text": "~Paste",
"type": "command",
"command": ".uno:Paste",
"enabled": "true"
},
{
"text": "Paste ~Special",
"type": "menu",
"command": ".uno:PasteSpecialMenu",
"menu": [
{
"text": "~Unformatted Text",
"type": "command",
"command": ".uno:PasteUnformatted",
"enabled": "true"
},
{
"text": "~More Options...",
"type": "command",
… console-export-2024-8-16_9-22-29.txt Peek.2024-08-16.09-22.mp4Then after closing that dialog and refreshing:
Peek.2024-08-16.09-23.mp4 |
@pedropintosilva, I am unable to reproduce the first two problems. Working on a fix for the third problem now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Catch and pass context menu key to core (respective core patch: https://gerrit.libreoffice.org/c/core/+/171914)
Once rendered context menu, focus it so we can continue navigating it with the keyboard
TODO
Checklist
make prettier-write
and formatted the code.make check
make run
and manually verified that everything looks okay