Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Add config option for specifying social links #37

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Add config option for specifying social links #37

merged 1 commit into from
Feb 7, 2018

Conversation

sumnerevans
Copy link
Member

@sumnerevans sumnerevans commented Dec 21, 2017 •
edited
Loading

Resolves #16.

Features

  • The sys admin can specify a list of social links to display in the footer using the .ini config file.

Notes

  • I wasn't sure how to make a dictionary in the .ini file. Any suggestions would be appreciated.
  • The helpers.fa_icon function is also in Project Listing Page #35. I didn't want to merge branches, so it's duplicated here.

@sumnerevans sumnerevans self-assigned this Dec 21, 2017
@sumnerevans
Copy link
Member Author

@jackrosenthal , this is on your plate for review.

@samsartor samsartor changed the base branch from master to develop January 31, 2018 02:22
samsartor
samsartor approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@samsartor samsartor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@samsartor samsartor merged commit d0902bb into develop Feb 7, 2018
@sumnerevans sumnerevans mentioned this pull request Feb 14, 2018
Merged
@jackrosenthal jackrosenthal deleted the social-footer branch May 27, 2018 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samsartor samsartor samsartor approved these changes

@jackrosenthal jackrosenthal Awaiting requested review from jackrosenthal

Assignees

@sumnerevans sumnerevans

Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sumnerevans @samsartor