Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed css issue #5398

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

Fixed css issue #5398

wants to merge 2 commits into from

Conversation

saviokmua
Copy link 

07:34:58 css.1  | warning ../../package.json: No license field
07:34:58 css.1  | $ sass ./app/assets/stylesheets/application.bootstrap.scss:./app/assets/builds/application.css --no-source-map --load-path=node_modules
07:34:59 css.1  | Error: 0.25rem and 0 are incompatible.
07:34:59 css.1  |      ╷
07:34:59 css.1  | 4892 │   border-radius: calc(0.25rem - 0) calc(0.25rem - 0) 0 0;
07:34:59 css.1  |      │                       ^^^^^^^^^^^
07:34:59 css.1  |      ╵
07:34:59 css.1  |   admin-lte/dist/css/adminlte.css 4892:23                @import

danny007in
danny007in reviewed Nov 1, 2023
View reviewed changes
dist/css/adminlte.css
@@ -4838,14 +4838,14 @@ input[type="button"].btn-block {

.card > .list-group:first-child {
border-top-width: 0;
border-top-left-radius: calc(0.25rem - 0);
border-top-right-radius: calc(0.25rem - 0);
border-top-left-radius: calc(0.25rem);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better is

 border-top-left-radius: 0.25rem;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danny007in thanks! fixed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@saviokmua saviokmua requested a review from danny007in November 3, 2023 17:55
@danny007in
Copy link
Collaborator

Please Check https://github.com/ColorlibHQ/AdminLTE/blob/v3/.github/CONTRIBUTING.md

@danny007in
Copy link
Collaborator

please make changes in .scss file, .css files are compiled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Navisystem77 Navisystem77 Navisystem77 left review comments

@danny007in danny007in Awaiting requested review from danny007in

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
state:awaiting-reply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saviokmua @danny007in @Navisystem77