Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a file for assertions #424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce a file for assertions #424

wants to merge 1 commit into from

Commits on Sep 28, 2023

  1. Introduce a file for assertions 

    We have a smattering of assertions in different files within the
`framework` package. Even if you rely on your IDE to fill these in for
you, organizing them is good practice.

This commit adds a new file specifically for assertions, and populates
it with an existing assertion used in tests.

It also implements the ability for assertions to handle test outcomes,
instead of returning booleans, forcing the callers to handle test
outcomes. Although having test outcomes (e.g., `FailNow`) in the test is
clear, we check and call `Fatal` a lot across the test code. Moving the
outcome into the assertion allows the code to be a little more dry, and
clear if everyone agrees assertions should accept that reponsibility.
    @rhmdnd
    rhmdnd committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4fee621 View commit details
    Browse the repository at this point in the history