Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.75.2 #480

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Nov 18, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/prometheus-operator/prometheus-operator/pkg/client v0.68.0 -> v0.75.2 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

prometheus-operator/prometheus-operator (github.com/prometheus-operator/prometheus-operator/pkg/client)

v0.75.2

Compare Source

v0.75.1: 0.75.1 / 2024-07-02

Compare Source

  • [BUGFIX] Fix OVHCloud service discovery configs key error. #​6723

v0.75.0: 0.75.0 / 2024-06-26

Compare Source

  • [CHANGE] Global limits over enforced limits when no user limits are set. #​6608
  • [CHANGE/BUGFIX] Use a separate port number (8081) for the init container. #​6635
  • [FEATURE] Add source field in pagerdutyConfigs in AlertManangerConfig CRD. #​6427
  • [FEATURE] Add DockerSwarm Service Discovery support in the ScrapeConfig CRD. #​6633
  • [FEATURE] Add Linode Service Discovery support in the ScrapeConfig CRD. #​6586
  • [FEATURE] Add PuppetDB Service Discovery support in the ScrapeConfig CRD. #​6651
  • [FEATURE] Add LightSail Service Discovery support in the ScrapeConfig CRD. #​6660
  • [FEATURE] Add OVHCloud Service Discovery support in the ScrapeConfig CRD. #​6689
  • [FEATURE] Add extra metric relabelings to scrape classes. #​6492
  • [FEATURE] Add jobName field to ScrapeConfig CRD. #​6618
  • [FEATURE] Add automatic memory limit handling using the flag -auto-gomemlimit-ratio. #​6591
  • [FEATURE] Add support for ProxyConfig in Prometheus RemoteWrite and RemoteRead specs. #​6512
  • [ENHANCEMENT] Add automatic GOMAXPROCS to admission webhook. #​6599
  • [ENHANCEMENT] Add prometheus_operator_feature_gate_info metric. #​6655
  • [BUGFIX] Fix reloading Alertmanager when notification templates change. #​6607
  • [BUGFIX] Fix PrometheusAgent reconciliation for the statefulset changes. #​6615
  • [BUGFIX] Fix readiness/liveness probes for config-reloader when listenLocal is set to true. #​6698

v0.74.0: 0.74.0 / 2024-05-17

Compare Source

  • [CHANGE/BUGFIX] Change the proxyConnectHeader field of the proxy configuration in the ScrapeConfig CRD from a map of strings to a map of string slices. #​6541
  • [CHANGE] Automatically set the GOMAXPROCS variable according to the CPU limits of the process cgroup. #​6576
  • [FEATURE] Add support for the Nomad Service Discovery to the ScrapeConfig CRD. #​6485
  • [FEATURE] Add relabelings field for Alertmanager's endpoints in the Prometheus CRD. #​6467
  • [FEATURE] Add alertRelabelings field for the Alertmanager's endpoints in the Prometheus CRD. #​6450
  • [FEATURE] Add support for the Azure SDK authentication to the Azure Service Discovery in the ScrapeConfig CRD. #​6595
  • [FEATURE] Add support for the Azure SDK authentication to the remote-write configuration in the Prometheus and PrometheusAgent CRDs. #​6596
  • [ENHANCEMENT] Add Go runtime scheduler metrics to the operator. #​6563
  • [ENHANCEMENT] Add go_sync_mutex_wait_total_seconds_total metric to the operator. #​6581
  • [BUGFIX] Allow templated strings for the responder's type in OpsGenie configuration. #​6378
  • [BUGFIX] Fix nil pointer panic in the AlertmanagerConfig Webex receiver. #​6582
  • [BUGFIX] Apply TLS scrape class settings to all PodMonitor, Probe and ScrapeConfig objects. #​6573

v0.73.2: 0.73.2 / 2024-04-18

Compare Source

  • [BUGFIX] Fix ScrapeClassTLSConfig nil pointer exception. #​6526
  • [BUGFIX] Fix missing prometheus_operator_kubernetes_client_http_requests_total metric. #​6525

v0.73.1: 0.73.1 / 2024-04-10

Compare Source

  • [BUGFIX] To minimize excessive logging, log the deprecated bearer token fields at the debug level. #​6495

v0.73.0: 0.73.0 / 2024-04-03

Compare Source

  • [CHANGE/BUGFIX] Add proxyURL validation for ServiceMonitor, PodMonitor and Probe objects. It could be a breaking change for those who rely on the configuration reloader sidecar to expand environment variables in the generated configuration file. #​6464
  • [CHANGE/BUGFIX] Allow empty separator in relabel config. #​6425
  • [FEATURE] Add summary field to the MSteams receiver. #​6206
  • [FEATURE] Add support for Kuma SD in ScrapeConfig CRD. #​6427,#​6465
  • [FEATURE] Add support for Eureka SD in ScrapeConfig CRD. #​6408
  • [FEATURE] Add support for Docker SD in ScrapeConfig CRD. #​6421
  • [FEATURE] Add support for Hetzner SD in ScrapeConfig CRD. #​6436
  • [FEATURE] Add the --kubelet-node-address-priority CLI argument to set the node address priority. #​6377
  • [FEATURE] Add relabelings field to scrape classes. #​6379
  • [FEATURE] Add bodySizeLimit field to the ServiceMonitor and PodMonitor CRDs. #​6349
  • [FEATURE] Add sampleAgeLimit field to the remote-write configuration. #​6326
  • [ENHANCEMENT] Verify which CRDs are installed and start the respective controllers only when needed. #​6351
  • [ENHANCEMENT] Add checks for selectors in KubernetesSDConfig. #​6359
  • [BUGFIX] Fix ScrapeConfigs selection issue across different namespaces. #​6390
  • [BUGFIX] Add check to determine if Thanos supports the --prometheus.http-client flag. #​6448
  • [BUGFIX] Fix PrometheusAgent reconciliation when the secret/configmap's namespace is different from the PrometheusAgent namespace. #​6412
  • [BUGFIX] Fix the validation for muteTimeIntervals's months in the AlertmanagerConfig CRD. #​6362

v0.72.0: 0.72.0 / 2024-03-04

Compare Source

In this release, we want to highlight the addition of ScrapeClasses.

ScrapeClasses is an experimental feature that allows declaring multiple scrape configurations in the Prometheus/PrometheusAgent objects that can be consumed by selected scrape-related resources, like ScrapeConfig, ServiceMonitor, PodMonitor and Probes. Initial support only allows the declaration of TLS configuration, but we plan to extend ScrapeClasses with more options in the future, e.g. Authorization, relabelings and scrape protocols.

  • [FEATURE] Add ScrapeClasses to Prometheus, PrometheusAgent, ScrapeConfig, ServiceMonitor, PodMonitor and Probe CRDs. #​6199
  • [FEATURE] Add the enableCompression field to the ScrapeConfig CRD. #​6236
  • [FEATURE] Add DigitalOcean service discovery to the ScrapeConfig CRD. #​6220
  • [FEATURE] Add support for scrapeProtocols to the ScrapeConfig, ServiceMonitor and PodMonitor CRDs. #​6235 #​6268
  • [FEATURE] Add support for NS records to the DNS service discovery in the ScrapeConfig CRD. #​6235
  • [FEATURE] Add support for keepFiringFor in the ThanosRuler CRD. #​6283
  • [ENHANCEMENT] Enable usage of sharding with ScrapeConfig. #​6135
  • [BUGFIX] Correctly mount file subpaths in ThanosRuler CRD. #​6243
  • [BUGFIX] Fix conversion of the continue field in AlertmanagerConfig between v1alpha1 and v1beta1 versions. #​6282
  • [BUGFIX] Fix failure of metadata informers when processing deleted objects. #​6298

v0.71.2: 0.71.2 / 2024-01-25

Compare Source

  • [BUGFIX] Fix Azure SD service discovery when using ManagedIdentity. #​6259

v0.71.1: / 2024-01-22

Compare Source

  • [BUGFIX] Pass all the ThanosRuler .spec.volumes fields down to the pods. #​6249

v0.71.0: 0.71.0 / 2024-01-12

Compare Source

  • [CHANGE] Configure the configuration reloader sidecar with the same web configuration as Prometheus and Alertmanager. #​6194
  • [FEATURE] Implement the Scale subresource for the Prometheus and PrometheusAgent CRDs. #​5962
  • [FEATURE] Add support for OpenStack Service Discovery to the ScrapeConfig CRD. #​6168
  • [FEATURE] Add support for all settings of the Kubernetes Service Discovery to the ScrapeConfig CRD. #​6178
  • [FEATURE] Add support for proxy settings to the ScrapeConfig CRD. #​6001
  • [FEATURE] Add the enableHTTP2 field to remote-write configuration. #​6192
  • [FEATURE] Add .spec.maximumStartupDurationSeconds to the Prometheus and PrometheusAgent CRDs. #​6137
  • [FEATURE] Emit Kubernetes events when detecting invalid configurations. #​6179
  • [ENHANCEMENT] Add additionalLabels field to topology spread constraints for Prometheus and PrometheusAgent CRD. #​5967
  • [ENHANCEMENT] Add .spec.clusterLabel to the Alertmanager CRD. #​6162
  • [ENHANCEMENT] Add prometheus_operator_status_update_errors_total and prometheus_operator_status_update_operations_total metrics. #​6185

v0.70.0: 0.70.0 / 2023-11-30

Compare Source

  • [CHANGE] Use camelCase on scrapeConfig in prometheus job names. #​6124
  • [CHANGE] Update field names for ConsulSD configs. #​6094
  • [FEATURE] Add trackTimestampsStaleness field to ServiceMonitor, PodMonitor and ScrapeConfig CRDs. #​6105
  • [FEATURE] Add persistentVolumeClaimRetentionPolicy field to the Prometheus and PrometheusAgent CRDs. #​6038
  • [FEATURE] Support service,pod,endpoints,endpointslice,ingress roles to KubernetesSDConfigs in ScrapeConfig CRD. #​6089
  • [FEATURE] Add support for Azure SD and GCE SD in ScrapeConfig CRD. #​6078 #​6009
  • [FEATURE] Add azure AD oauth support to remote write. #​6037
  • [FEATURE] Add .spec.reloadStrategy to the Prometheus and PrometheusAgent CRDs. The value can be HTTP (default if not specified) or ProcessSignal. #​5690
  • [ENHANCEMENT] Expose flag to enable the reloader probes in the jsonnet configuration. #​6075
  • [ENHANCEMENT] Reduce memory usage for clusters with large number of secrets and/or configmaps. #​5993
  • [ENHANCEMENT] Config reloader now sends all logs to os.Stdout. #​6085
  • [BUGFIX] Remove verbose logging in admission-webhook pods. #​6095
  • [BUGFIX] Fixed HTTP scheme value in the Consul SD configurations. #​6098
  • [BUGFIX] Skip adding shard relabel rules if they were already set in additionalScrapeConfigs. #​6099
  • [BUGFIX] Fix nil pointer exception when title and text are not set in MS Teams config. #​6109

v0.69.1: 0.69.1 / 2023-11-09

Compare Source

This release is built using Go 1.21.4 which addresses CVE-2023-45283 and CVE-2023-45284.

  • [BUGFIX] Rename test files to resolve Go import failures of github.com/prometheus-operator/prometheus-operator. #​6070

v0.69.0: 0.69.0 / 2023-11-03

Compare Source

  • [CHANGE] Consider secret references without optional value to be mandatory instead of optional for .spec.additionalScrapeConfigs configs. #​5985
  • [CHANGE] Remove prometheus_operator_rule_validation_triggered_total, prometheus_operator_rule_validation_errors_total, prometheus_operator_alertmanager_config_validation_triggered_total and prometheus_operator_alertmanager_config_validation_errors_total metrics which have been deprecated since v0.55.0. The same information is available from the apiserver_admission_webhook_rejection_count metric available since Kubernetes v1.16.0. #​6024
  • [CHANGE/BUGFIX] Disable HTTP2 connections by default to mitigate CVE-2023-44487. #​6028
  • [FEATURE] Add support for EC2 service discovery to the ScrapeConfig CRD. #​5902 #​6012
  • [FEATURE] Support MSTeams receiver in the AlertmanagerConfig CRD. #​6002
  • [FEATURE] Add the sigv4 field to the Alertmanager endpoints for the Prometheus CRD. #​6036
  • [FEATURE] Support AzureAD authentication for Prometheus remote write. #​5852
  • [FEATURE] Add the userKeyFile and tokenFile fields for Pushover to the AlertmanagerConfig CRD. #​5886
  • [FEATURE] Add --as to the operator's CLI arguments for user impersonation. #​5906
  • [FEATURE] Add the selectors field for the Kubernetes service discovery to the ScrapeConfig CRD. #​6053
  • [ENHANCEMENT] Support url_file for Webhook receiver in the Alertmanager configuration. #​5876
  • [ENHANCEMENT] Support user_key_file and token_file for Pushover receiver in the Alertmanager configuration. #​5876
  • [ENHANCEMENT] Use server-side apply instead of update when reconciling the resource's status. #​5883 #​5913 #​5912
  • [ENHANCEMENT] Detect when an invalid storage class is defined. #​5792
  • [ENHANCEMENT] Add OCI labels to container images. #​5946
  • [ENHANCEMENT] Add the operator.prometheus.io/version annotation to the CRD manifests. #​6050
  • [BUGFIX] Detect namespace changes without list/watch permissions on the namespace resources. #​5934 #​5898
  • [BUGFIX] Avoid operator panic when using ScrapeConfig with the Consul service discovery. #​5937
  • [BUGFIX] Don't enable Prometheus unmanaged mode when only .spec.scrapeConfigSelector is defined. #​5941
  • [BUGFIX] Prevent Alertmanager pods from joining random clusters. #​5945
  • [BUGFIX] Fix race condition when deleting Alertmanager, Prometheus, PrometheusAgent and ThanosRuler instances. #​5954
  • [BUGFIX] Enable klog verbose level only when the log level is debug.. #​5981
  • [BUGFIX] Reduce memory usage by using secret metadata informer in the PrometheusAgent controller. #​5982
  • [BUGFIX] Do not strip mandatory fields in the stripped-down-crds.yaml manifest file. #​6008
  • [BUGFIX] Update the resource requests and limits of the config reloader sidecar when updated. #​5971

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

openshift-ci bot commented Nov 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renovate[bot]
Once this PR has been reviewed and has the lgtm label, please assign jhrozek for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Nov 18, 2023

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from c012a92 to b37e7d9 Compare November 30, 2023 16:12
@renovate renovate bot changed the title fix(deps): update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.69.1 fix(deps): update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.70.0 Nov 30, 2023
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from b37e7d9 to 4c7d6f0 Compare January 12, 2024 11:17
@renovate renovate bot changed the title fix(deps): update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.70.0 fix(deps): update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.0 Jan 12, 2024
@renovate renovate bot changed the title fix(deps): update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.0 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.0 Jan 16, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 4c7d6f0 to 7aff6bc Compare January 24, 2024 10:47
@renovate renovate bot changed the title Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.0 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.1 Jan 24, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 7aff6bc to 4768808 Compare January 25, 2024 16:47
@renovate renovate bot changed the title Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.1 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.2 Jan 25, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 4768808 to c56ce56 Compare January 28, 2024 14:01
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:480

@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from c56ce56 to bbcf4dc Compare February 25, 2024 10:05
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:480

@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from bbcf4dc to 8302c19 Compare March 4, 2024 18:59
@renovate renovate bot changed the title Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.71.2 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.72.0 Mar 4, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch 2 times, most recently from 7af8fd7 to 141ce34 Compare April 4, 2024 12:13
@renovate renovate bot changed the title Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.72.0 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.73.0 Apr 4, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 141ce34 to 1720096 Compare April 11, 2024 13:54
@renovate renovate bot changed the title Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.73.0 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.73.1 Apr 11, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 1720096 to 4de62a4 Compare April 19, 2024 17:26
@renovate renovate bot changed the title Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.73.1 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.73.2 Apr 19, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch 6 times, most recently from ca2be77 to bb0d8e6 Compare July 24, 2024 06:41
@renovate renovate bot changed the title Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.75.1 Update module github.com/prometheus-operator/prometheus-operator/pkg/client to v0.75.2 Jul 24, 2024
@renovate renovate bot force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch 5 times, most recently from d156998 to 17aa344 Compare July 30, 2024 17:10
Copy link
Author

renovate bot commented Jul 30, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:480

@rhmdnd
Copy link

rhmdnd commented Jul 30, 2024

/retest-required

Unrelated errors

@rhmdnd rhmdnd force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from cf78bd8 to 5850485 Compare July 30, 2024 22:36
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:480

@rhmdnd rhmdnd force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 5850485 to 14ad86e Compare July 31, 2024 12:45
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:480

@rhmdnd rhmdnd force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 14ad86e to 2185517 Compare August 5, 2024 21:43
Copy link

github-actions bot commented Aug 5, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:480

@rhmdnd rhmdnd force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from 2185517 to f567929 Compare August 6, 2024 12:10
renovate bot and others added 2 commits August 6, 2024 08:51
The function for `SafeTLSConfig` changed to accept a pointer to a
string instead of a string. Update our usage so that the dependency bump
doesn't fail.
@rhmdnd rhmdnd force-pushed the renovate/github.com-prometheus-operator-prometheus-operator-pkg-client-0.x branch from f567929 to 6bf72ae Compare August 6, 2024 13:51
Copy link

openshift-ci bot commented Aug 6, 2024

@renovate[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-parallel 6bf72ae link true /test e2e-aws-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

github-actions bot commented Aug 6, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:480

@rhmdnd rhmdnd added this to the 1.6.0 milestone Aug 9, 2024
@rhmdnd rhmdnd removed this from the 1.6.0 milestone Aug 30, 2024
@rhmdnd rhmdnd added this to the 1.6.1 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant