Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Makefile target for pushing must-gather image #546

Merged

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Jul 17, 2024

The must-gather target had a reference to a non-existent target called
must-gather-push, which resulted in the following error when you
attempted to build the must-gather image locally:

make: *** No rule to make target 'must-gather-push', needed by 'must-gather'. Stop.

This commit adds in the missing Makefile target to push the image to a
specific image registry so that you can build must-gather images locally
and push them to your own registry (e.g., useful for testing).

The must-gather target had a reference to a non-existent target called
`must-gather-push`, which resulted in the following error when you
attempted to build the must-gather image locally:

  make: *** No rule to make target 'must-gather-push', needed by 'must-gather'.  Stop.

This commit adds in the missing Makefile target to push the image to a
specific image registry so that you can build must-gather images locally
and push them to your own registry (e.g., useful for testing).
Copy link

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd rhmdnd requested review from yuumasato, xiaojiey and BhargaviGudi and removed request for mrogers950 July 17, 2024 18:43
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:546

@BhargaviGudi
Copy link
Collaborator

/hold for test

@BhargaviGudi
Copy link
Collaborator

Verification passed with 4.17.0-0.nightly-2024-07-07-131215 + #546

podman build -t quay.io/bgudi/must-gather-ocp:pr-543-3 -f images/must-gather/Dockerfile .
STEP 1/4: FROM quay.io/openshift/origin-must-gather:latest
Trying to pull quay.io/openshift/origin-must-gather:latest...
Getting image source signatures
Copying blob 69535de51c02 done   | 
Copying blob 28d6057e65ce done   | 
Copying blob 47318e52445e done   | 
Copying blob 97da74cc6d8f done   | 
Copying blob 39168a15419f done   | 
Copying blob d8190195889e done   | 
Copying blob ca09db8018f6 done   | 
Copying config 9be99b5355 done   | 
Writing manifest to image destination
STEP 2/4: RUN mv /usr/bin/gather /usr/bin/gather_original
--> 5294cb4a3832
STEP 3/4: COPY utils/must-gather/* /usr/bin/
--> 663eed2d5891
STEP 4/4: ENTRYPOINT /usr/bin/gather
COMMIT quay.io/bgudi/must-gather-ocp:pr-543-3
--> 4faa721b81c3
Successfully tagged quay.io/bgudi/must-gather-ocp:pr-543-3
4faa721b81c307896fb1b9a43ec704cc25f32d8b2db271da13729632f7d57a0f
podman push quay.io/bgudi/must-gather-ocp:pr-543-3
Getting image source signatures
Copying blob 39168a15419f skipped: already exists  
Copying blob 47318e52445e skipped: already exists  
Copying blob 69535de51c02 skipped: already exists  
Copying blob d8190195889e skipped: already exists  
Copying blob 7fa6c8e19cf7 done   | 
Copying blob 09c74ccd0df1 done   | 
Copying blob 28d6057e65ce skipped: already exists  
Copying blob 97da74cc6d8f skipped: already exists  
Copying blob ca09db8018f6 skipped: already exists  
Copying config 4faa721b81 done   | 
Writing manifest to image destination

@BhargaviGudi
Copy link
Collaborator

/unhold

@BhargaviGudi
Copy link
Collaborator

BhargaviGudi commented Jul 18, 2024

/label qe-approved

@rhmdnd
Copy link
Author

rhmdnd commented Jul 18, 2024

ROSA e2e tests are failing on quota issues with AWS. Working on resolving them, but their unrelated to this patch.

@rhmdnd
Copy link
Author

rhmdnd commented Jul 18, 2024

/test e2e-rosa

3 similar comments
@rhmdnd
Copy link
Author

rhmdnd commented Jul 18, 2024

/test e2e-rosa

@rhmdnd
Copy link
Author

rhmdnd commented Jul 18, 2024

/test e2e-rosa

@rhmdnd
Copy link
Author

rhmdnd commented Jul 19, 2024

/test e2e-rosa

@rhmdnd
Copy link
Author

rhmdnd commented Jul 19, 2024

Unable to recreate this locally on a ROSA cluster... Retesting to get better logs.

@rhmdnd
Copy link
Author

rhmdnd commented Jul 22, 2024

Closes #159

@Vincent056
Copy link

/lgtm

@rhmdnd
Copy link
Author

rhmdnd commented Jul 22, 2024

/test e2e-rosa

Failed on image streams, which seems unrelated.

@rhmdnd
Copy link
Author

rhmdnd commented Jul 22, 2024

/test e2e-rosa

Ugh - another deployment timeout failure... Opening a bug so we can track this separately and find a way to deal with it.

@Vincent056
Copy link

Available cluster versions:
4.16.2
4.16.1
4.16.0
4.15.21
4.15.20
4.15.19
4.15.18
4.15.17
4.15.16
4.15.15
4.14.33
4.14.32
4.14.31
4.14.30
4.14.29
4.14.28
Requested cluster version not available!

not related error

@rhmdnd
Copy link
Author

rhmdnd commented Jul 23, 2024

Proposed a PR that attempts to update the ROSA CI version.

openshift/release#54704

@rhmdnd
Copy link
Author

rhmdnd commented Jul 24, 2024

/test e2e-rosa

@openshift-merge-bot openshift-merge-bot bot merged commit bef0496 into ComplianceAsCode:master Jul 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants