Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive forward attribute #314

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Derive forward attribute #314

merged 7 commits into from
Jul 14, 2023

Conversation

limemloh
Copy link
Collaborator

@limemloh limemloh commented Jul 10, 2023 •
edited
Loading

Purpose

Closes #307
Related to #307.
Should be merged after Concordium/concordium-contracts-common#102.
Test new support of forward attribute in derive macros for Serial, Deserial, DeserialWithState and SchemaType.

Changes

  • Add a number of tests for new derive macro features

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@limemloh limemloh mentioned this pull request Jul 10, 2023
Merged
5 tasks
@limemloh limemloh marked this pull request as ready for review July 10, 2023 14:01
@limemloh limemloh requested review from abizjak and DOBEN July 10, 2023 14:02
abizjak
abizjak approved these changes Jul 12, 2023
View reviewed changes
concordium-std/CHANGELOG.md Outdated Show resolved Hide resolved
DOBEN
DOBEN approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to simplify the cis3 sponsored transaction event schema as well. Can be done in a separate PR so.

@limemloh limemloh merged commit ece329d into main Jul 14, 2023
121 checks passed
@limemloh limemloh deleted the derive-forward-attribute branch July 14, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abizjak abizjak abizjak approved these changes

@DOBEN DOBEN DOBEN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging custom events as well as standardized ones
3 participants
@limemloh @abizjak @DOBEN